Skip to content

Commit

Permalink
Limit numpy version for Windows only
Browse files Browse the repository at this point in the history
Github Action tests found a numerical difference on one test, but only
on Windows and unrelated to code changes. Numpy update is a likely
suspect, and pinning seems to prevent the issue. Make this pin
OS-dependent for now, and see what happens. Will be interesting to see
if it also applies to Conda builds...
  • Loading branch information
ajjackson committed Sep 18, 2024
1 parent e98e40b commit 7e58333
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def run_setup():
include_package_data=True,
install_requires=[
'packaging',
'numpy>=1.24.0,<2.1',
'numpy>=1.24.0,<2.1' if "win" in platform else 'numpy>=1.24.0',

Check failure on line 142 in setup.py

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

setup.py#L142

Undefined variable 'platform'
'scipy>=1.10',
'seekpath>=1.1.0',
'spglib>=1.9.4',
Expand Down

0 comments on commit 7e58333

Please sign in to comment.