Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing build/test failures #312

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Fixing build/test failures #312

merged 8 commits into from
Jul 31, 2024

Conversation

ajjackson
Copy link
Collaborator

@ajjackson ajjackson commented Jul 31, 2024

Tests are broken overnight at build stage, despite no change to euphonic code. The setup.py build can no longer find Numpy, which has clearly been installed beforehand.

Could be a setuptools update? A lot of projects have been burned by removal of setuptools.command.test but we don't use that.

Tests are broken overnight at build stage, despite no change to
euphonic code. Could be a setuptools update?
@ajjackson
Copy link
Collaborator Author

ajjackson commented Jul 31, 2024

Pinning to <72 has not helped. There is something interesting in the error message, though

Building wheels for collected packages: euphonic
  Building wheel for euphonic (pyproject.toml): started
  Building wheel for euphonic (pyproject.toml): finished with status 'error'
  error: subprocess-exited-with-error
  
  × Building wheel for euphonic (pyproject.toml) did not run successfully.

Why does this mention pyproject.toml when Euphonic does not use such a thing?

In yesterday's successful build:

Building wheels for collected packages: euphonic
  Building wheel for euphonic (setup.py): started
  Building wheel for euphonic (setup.py): finished with status 'done'

Copy link
Contributor

github-actions bot commented Jul 31, 2024

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit b457971. ± Comparison against base commit 994a4e4.

♻️ This comment has been updated with latest results.

@ajjackson
Copy link
Collaborator Author

ajjackson commented Jul 31, 2024

It looks like the cause here is a double-whammy of setuptools and the missing wheel dependency from conda: I have to add both of these to the tox requirements to get things working again locally. Let's see how that maps to Github Actions...

It seems like quite the coincidence that both problems would arise simultaneously, so I must be missing something 🤔

@ajjackson ajjackson marked this pull request as ready for review July 31, 2024 14:27
@ajjackson
Copy link
Collaborator Author

Ok, pinning both setuptools and wheel versions seems to do the trick.

At some point it would be nice to rework the configuration to use pyproject.toml, and that might work with a newer setuptools. But that's a big job in its own right and not needed to get this working again for now.

@ajjackson ajjackson changed the title WIP investigating build/test failures Fixing build/test failures Jul 31, 2024
@ajjackson ajjackson enabled auto-merge (squash) July 31, 2024 14:33
@ajjackson ajjackson merged commit d1292be into master Jul 31, 2024
9 checks passed
@ajjackson ajjackson deleted the gh-requirements branch December 12, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant