-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing build/test failures #312
Conversation
Tests are broken overnight at build stage, despite no change to euphonic code. Could be a setuptools update?
Pinning to <72 has not helped. There is something interesting in the error message, though
Why does this mention pyproject.toml when Euphonic does not use such a thing? In yesterday's successful build:
|
It seems that the github conda runners no longer ship wheel with Python so we need to include it explicitly
1d86119
to
e693aea
Compare
It looks like the cause here is a double-whammy of setuptools and the missing wheel dependency from conda: I have to add both of these to the tox requirements to get things working again locally. Let's see how that maps to Github Actions... It seems like quite the coincidence that both problems would arise simultaneously, so I must be missing something 🤔 |
Ok, pinning both setuptools and wheel versions seems to do the trick. At some point it would be nice to rework the configuration to use pyproject.toml, and that might work with a newer setuptools. But that's a big job in its own right and not needed to get this working again for now. |
b457971
to
f11d07f
Compare
Tests are broken overnight at build stage, despite no change to euphonic code. The setup.py build can no longer find Numpy, which has clearly been installed beforehand.
Could be a setuptools update? A lot of projects have been burned by removal of
setuptools.command.test
but we don't use that.