Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop raven in favor of sentry-go #383

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Drop raven in favor of sentry-go #383

wants to merge 3 commits into from

Conversation

monstermunchkin
Copy link
Contributor

Closes #367

@monstermunchkin monstermunchkin self-assigned this Oct 9, 2024
@monstermunchkin monstermunchkin mentioned this pull request Oct 9, 2024
Closed
srieckhof
srieckhof reviewed Dec 10, 2024
View reviewed changes
maintenance/errors/error.go
@@ -106,7 +126,7 @@ func HandleError(rp interface{}, handlerName string, w http.ResponseWriter, r *h
}
log.Stack(ctx)

sentryEvent{ctx, r, rp, 1, handlerName}.Send()
sentry.CaptureEvent(getEvent(ctx, r, rp, 1, handlerName))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we find a better variable name for rp? It seems to be type any. But it's hard to grasp.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for other usages inside this file...

maintenance/errors/error.go
}

// from env
packet.Extra["microservice"] = os.Getenv("JAEGER_SERVICE_NAME")
event.Extra["microservice"] = os.Getenv("JAEGER_SERVICE_NAME")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a side question: When will we be able to drop or change this env var? Because we don't actually use Jaeger anymore...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srieckhof srieckhof srieckhof left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@monstermunchkin monstermunchkin

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace raven with sentry-go
2 participants
@monstermunchkin @srieckhof