Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces cran fixes #161

Merged
merged 2 commits into from
Jun 12, 2018
Merged

Spaces cran fixes #161

merged 2 commits into from
Jun 12, 2018

Conversation

amoeba
Copy link
Contributor

@amoeba amoeba commented Jun 12, 2018

Meant to address our conversation in #140 and get the partial Spaces API ready for a CRAN release.

As per pachadotdev#140:

- Remove export tags from space_create and spaces_object_delete
- Add notes to the roxygen docstrings
- Add `stops` with a hopefully helpful error message that the fns are not implemented yet
- Re-document package
@sckott sckott added the spaces label Jun 12, 2018
@sckott sckott added this to the v0.7 milestone Jun 12, 2018
@sckott
Copy link
Collaborator

sckott commented Jun 12, 2018

looks good

@sckott sckott merged commit 8f1f569 into pachadotdev:master Jun 12, 2018
@amoeba
Copy link
Contributor Author

amoeba commented Jun 12, 2018

Thanks!

@sckott sckott modified the milestones: v0.7, v0.8 Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants