%setup → %autosetup -N unless -aN -aM
#93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
|
Build failed.
|
|
Build succeeded.
|
Sometimes packages have multiple sources (= archives) which they unpack during %prep in different ways. This can be done with `%setup -aN -aM`. Sadly `%autosetup -aN -aM` does not work: https://bugzilla.redhat.com/show_bug.cgi?id=1881840 So we need to turn back into overwriting %setup unless we detect this use case. But the eternal problem with patches applied in a subdir persists. Fixes some of packit#92 Signed-off-by: Tomas Tomecek <[email protected]>
Signed-off-by: Tomas Tomecek <[email protected]>
%setup -T means that rpm should not unpack source0 - if we turn %setup into %autosetup thus getting a git repo after running it, we'll get an empty git repo - bad. These cases usually unpack/construct the source tree in %prep in a custom way. It would result into first patch containing the whole source tree - we don't want that. With this change, we'll create the git repo before applying first patch which should match the initial source tree. I hope it's clear we are getting into depths of odd packaging Related packit#85 Signed-off-by: Tomas Tomecek <[email protected]>
|
Build succeeded.
|
lachmanfrantisek
approved these changes
Oct 9, 2020
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes packages have multiple sources (= archives) which they unpack
during %prep in different ways. This can be done with
%setup -aN -aM.Sadly
%autosetup -aN -aMdoes not work: https://bugzilla.redhat.com/show_bug.cgi?id=1881840So we need to turn back into overwriting %setup unless we detect this
use case.
But the eternal problem with patches applied in a subdir persists.
Fixes some of #92