chore(tests): unpin pytest #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the breaking change (deprecation) in pytest=8.1.1 has been already fixed in flexmock¹, unpin pytest and also install flexmock from the PyPI rather than RPM (to ensure the same behavior even if we switched back to the CentOS images). Newer version of pytest introduces ‹PYTEST_VERSION› environment variable that can be used to detect whether the tests are being run or not, which is used in some safe-guards in the events-refactor². ¹ flexmock/flexmock#153 ² packit#2590 Signed-off-by: Matej Focko <[email protected]>
mfocko
force-pushed
the
chore/pytest-flexmock
branch
from
db1ed11 to
1fe6d25
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 45s |
nforro
approved these changes
Jan 23, 2025
lbarcziova
approved these changes
Jan 23, 2025
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 47s |
softwarefactory-project-zuul
bot
merged commit 2dfec18
into
packit:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the breaking change (deprecation) in pytest=8.1.1 has been already fixed in flexmock¹, unpin pytest and also install flexmock from the PyPI rather than RPM (to ensure the same behavior even if we switched back to the CentOS images).
Newer version of pytest introduces ‹PYTEST_VERSION› environment variable that can be used to detect whether the tests are being run or not, which is used in some safe-guards in the events-refactor².
¹ flexmock/flexmock#153
² #2590