Use Rust FFI #15: Remove StubServerHttpService #346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stub server is started, it may serve various requests/responses:
I remove
StubServerHttpService
because: It doesn't provide that flexibility. All it does is send aGET /endpoint
request with a single headerContent-Type: application/json
, and expect response to be json string. Why not let user install the package (e.g. guzzle) and send the request however they want?I also remove
GuzzleClient
because it doesn't do anything special. All it does is proxy calls to the actual guzzle client.We can remove those code so we don't have to maintain them.