Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Don't validate example value with regex #696

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Dec 2, 2024

  • Follow suggestion from @mefellows : the value must be correct type, no need to validate beforehand
  • This change allows the use of an empty string ('') instead of null as an example value when a generator is set. This way, we don't need to find a value that matches the regex, since the generator will replace that value later anyway.

@tienvx tienvx marked this pull request as ready for review December 2, 2024 06:17
@coveralls
Copy link

coveralls commented Dec 2, 2024

Pull Request Test Coverage Report for Build 12130655028

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 96.291%

Totals Coverage Status
Change from base Build 12130132873: -0.009%
Covered Lines: 2570
Relevant Lines: 2669

💛 - Coveralls

@tienvx tienvx merged commit c80f967 into pact-foundation:master Dec 14, 2024
20 checks passed
@tienvx tienvx deleted the dont-validate-regex branch December 14, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants