Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set basePath to empty string #17

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Allow to set basePath to empty string #17

merged 2 commits into from
Nov 16, 2023

Conversation

ElnSorokina
Copy link
Contributor

No description provided.

@leelaprasadv
Copy link
Member

@ElnSorokina changes look good, can you please add tests as well for the new changes?

@ElnSorokina
Copy link
Contributor Author

@ElnSorokina changes look good, can you please add tests as well for the new changes?

Added the emptyBasePath.yaml to reproduce my issue with the server URL and empty config base path and emptyBasePath.test.js to cover that change.
Here is the result report file without the change (double forward slash and zero coverage):
Pasted Graphic 11
Here is the result report with a bathPath change:
Pasted Graphic 12

@leelaprasadv leelaprasadv merged commit 25ef8b1 into pactumjs:main Nov 16, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leelaprasadv leelaprasadv leelaprasadv approved these changes

@ASaiAnudeep ASaiAnudeep ASaiAnudeep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElnSorokina @leelaprasadv @ASaiAnudeep