Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(localization): integrate l10n_flutter with Bloc for language management #30

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

phoenixit99
Copy link

@phoenixit99 phoenixit99 commented Nov 25, 2024

Integrated the l10n_flutter package to manage app translations dynamically, leveraging the Bloc pattern for state management. This implementation supports seamless language switching and provides a scalable structure for adding or updating translations.

  • Added localization JSON files for supported languages.
  • Set up Bloc for handling localization state.
  • Ensured all text strings are dynamically fetched based on the selected language.
  • Updated app architecture to support future language additions.

BREAKING CHANGE: All hardcoded text strings are replaced with localization keys, requiring JSON translation files for new languages.

@phoenixit99 phoenixit99 changed the title Implement Localization Management feat: Implement Localization Management Nov 25, 2024
@phoenixit99 phoenixit99 requested a review from Ja7ad November 25, 2024 10:13
@esmaeil-ahmadipour
Copy link
Collaborator

@phoenixit99 Due to non-compliance with clean commit standards, this commit message needs to be corrected.
Please review the documentation and update the commit message accordingly.

@esmaeil-ahmadipour esmaeil-ahmadipour marked this pull request as draft November 25, 2024 14:17
@phoenixit99 phoenixit99 changed the title feat: Implement Localization Management feat(localization): integrate l10n_flutter with Bloc for language management Nov 25, 2024
@phoenixit99
Copy link
Author

Thanks @esmaeil-ahmadipour .
I updated the commit following document. Please double check

@esmaeil-ahmadipour
Copy link
Collaborator

Thanks @esmaeil-ahmadipour . I updated the commit following document. Please double check

image

@phoenixit99
please edit latest commit message amend and push force :)

@esmaeil-ahmadipour esmaeil-ahmadipour added the feature Add/Create new feature label Nov 25, 2024
- Implemented the l10n_flutter package for managing app translations dynamically.
- Leveraged the Bloc pattern for localization state management.
- Added localization JSON files for supported languages.
- Ensured dynamic fetching of text strings based on the selected language.
- Updated app architecture to support future language additions.

BREAKING CHANGE:
All hardcoded text strings have been replaced with localization keys, requiring JSON translation files for new languages.
@phoenixit99 phoenixit99 force-pushed the feature/implement_localization_management branch from 4dc9d7e to 52b95b2 Compare November 26, 2024 03:39
@phoenixit99
Copy link
Author

phoenixit99 commented Nov 26, 2024

@esmaeil-ahmadipour Screenshot 2024-11-26 at 10 40 54 AM
I updated by push force. Please review

@phoenixit99 phoenixit99 self-assigned this Nov 26, 2024
@phoenixit99 phoenixit99 marked this pull request as ready for review November 26, 2024 03:44
@esmaeil-ahmadipour esmaeil-ahmadipour self-assigned this Nov 28, 2024
@esmaeil-ahmadipour esmaeil-ahmadipour force-pushed the feature/implement_localization_management branch from e653e5f to 2119921 Compare November 28, 2024 06:21
@esmaeil-ahmadipour esmaeil-ahmadipour force-pushed the feature/implement_localization_management branch 7 times, most recently from d81882a to c5de079 Compare November 28, 2024 06:57
- add Check Localization Files
- add Run Dart Format Check
@esmaeil-ahmadipour esmaeil-ahmadipour force-pushed the feature/implement_localization_management branch from c5de079 to e4bc69b Compare November 28, 2024 07:03
@esmaeil-ahmadipour esmaeil-ahmadipour linked an issue Nov 28, 2024 that may be closed by this pull request
@esmaeil-ahmadipour esmaeil-ahmadipour merged commit afee6b8 into develop Nov 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add/Create new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Localization Management
2 participants