feat: impl WelcomeScreen according to Figma design
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PouriaMoradi021
force-pushed
the
feat/implement-welcome-screen-desktop
branch
from
465cbb9 to
90f7231
Compare
- add some variables to arb files & generated translation files - rename `WelcomePage` to `WelcomeScreen` & update where it is used - impl `WelcomeScreen` widgets - add `primaryLight` color to AppColors - add some welcomeScreen png to project source - add/create `CustomFilledButton`
PouriaMoradi021
force-pushed
the
feat/implement-welcome-screen-desktop
branch
from
90f7231 to
d5d66db
Compare
PouriaMoradi021
force-pushed
the
feat/implement-welcome-screen-desktop
branch
from
6cd6fe5 to
c9e05f5
Compare
PouriaMoradi021
force-pushed
the
feat/implement-welcome-screen-desktop
branch
from
c9e05f5 to
cf20798
Compare
esmaeil-ahmadipour
approved these changes
Jan 31, 2025
|
|
||
| ///to-do #68: add components for this screen after designing process complete | ||
| /// by Pouria | ||
| class WelcomeScreen extends StatelessWidget { |
There was a problem hiding this comment.
@PouriaMoradi021, this screen needs to support multiple themes. The Figma design has been updated with new colors. We can redefine the colors in a separate issue and refactor them across In the whole application. I'll skip refactor this item for now and outline the refactoring plan in a new issue.
There was a problem hiding this comment.
issue 74 is created for resolve this item . #74
There was a problem hiding this comment.
ok i get it !
@esmaeil-ahmadipour
esmaeil-ahmadipour
force-pushed
the
feat/implement-welcome-screen-desktop
branch
from
94e3a76 to
ac651db
Compare
esmaeil-ahmadipour
force-pushed
the
feat/implement-welcome-screen-desktop
branch
from
1c468eb to
477504b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WelcomePagetoWelcomeScreen& update where it is usedWelcomeScreenwidgetsprimaryLightcolor to AppColors