feat: 메인페이지 레이아웃을 구현합니다 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- container: max-width: 1536px
|
폴더구조 나누고 컴포넌트의 레이아웃 위주로 구현한 간단한 작업이라 머지하겠습니다 ! |
KimHunJin
reviewed
Sep 16, 2023
Comment on lines
+1
to
+3
| export interface TagListProps { | ||
| tags: string[]; // TODO: tag값 union type으로 변경 | ||
| } |
There was a problem hiding this comment.
props 타입을 밖으로 빼시는군요!
뭔가 재사용 되지 않을 타입이라 view에 들어있는걸 선호하는데 다른 분들 생각이 궁금하네요.
There was a problem hiding this comment.
네, 기존에 스타일 및 타입 파일은 항상 별도로 분리하는 컨벤션으로 작업했었는데, 헌진님이 말씀하신 것 처럼 재사용되지 않는 타입 파일들은 따로 분리하지 않고, 재사용되는 타입일 경우에만 분리하는 방식도 좋아보이네요. 이 부분은 리펙토링할 때 참고해보겠습니다! 감사합니다
KimHunJin
reviewed
Sep 16, 2023
Comment on lines
+4
to
+5
| import { Moon, Sun } from 'lucide-react'; | ||
| import { useTheme } from 'next-themes'; |
There was a problem hiding this comment.
오.. 라이브러리를 잘 쓰지 않는편이다 보니 처음 보는 라이브러리들인데 좋은것들 알아갑니다~!
두 라이브러리 다 들어가서 조금 살펴보니 직접 구현할때 사용했던 방법들과 유사하게 되어있어서 나중에라도 참고해서 직접 만들어 보는것도 좋을거 같아요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 이슈 링크
#47
📖 작업 배경
🛠️ 구현 내용
💡 참고사항
🖼️ 스크린샷