refactor(home): 홈 페이지의 인기 아티클 태그를 styled component 기반으로 리팩토링합니다. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innocarpe
added
status: needs-healing
Base automatically changed from
carpe/refactor-home-component
to
team6/innocarpe
September 13, 2023 12:33
innocarpe
force-pushed
the
carpe/refactor-article-list-component
branch
from
324cbe2 to
40de7a3
Compare
innocarpe
requested review from
InSeong-So,
areumsheep,
ludacirs and
limgyumin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 이슈 링크
📖 작업 배경
🛠️ 구현 내용
PopularArticleTagList로 리네이밍합니다. 실제 결과물과 최대한 비슷한 네이밍을 사용하는게 향후 가독성 측면에서 유리하다 판단했습니다.col-md-3스타일이 필요했는데,PopularArticleTagListContainer로 한 방에 풀 수 있는 방법을 못 찾아서, 어쩔 수 없이shared/쪽에Col.styled.ts를 만들어 놓고 이걸 활용하는 식으로 만들었습니다.💡 참고사항
🖼️ 스크린샷
기존과 동일하게 스타일이 잘 표시되고 있는 상태