Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [P4PU-848] update routing and error handling in PreLoginLayout #249

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

stratoivandiluccio
Copy link
Contributor

@stratoivandiluccio stratoivandiluccio commented Feb 18, 2025

List of Changes

This PR updated layout for some error pages and for p.p. & t.o.s. page

Motivation and Context

this is required because the previous layout was not aligned to the product's mockup and guidelines

How Has This Been Tested?

tested via:

  • unit tests
  • manual tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@stratoivandiluccio stratoivandiluccio changed the title feat: [P4PU-848] update routing and error handling in PreLoginLayout fix: [P4PU-848] update routing and error handling in PreLoginLayout Feb 18, 2025
@stratoivandiluccio stratoivandiluccio self-assigned this Feb 18, 2025
@stratoivandiluccio stratoivandiluccio marked this pull request as ready for review February 18, 2025 14:19
Copy link

github-actions bot commented Feb 19, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 95.81% (🎯 80%) 3911 / 4082
🔵 Statements 95.81% 3911 / 4082
🔵 Functions 88.38% 175 / 198
🟢 Branches 86.6% (🎯 80%) 388 / 448
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/PreLoginLayout.tsx 100% 66.66% 100% 100%
src/components/AssistanceForm/AssistanceForm.tsx 94.44% 86.36% 100% 94.44% 38, 41-47, 49
src/components/Cart/CartDrawer.tsx 90.36% 87.5% 60% 90.36% 28-29, 115-120
Generated in workflow #312 for commit 4d7be4c by the Vitest Coverage Report Action

@stratoivandiluccio stratoivandiluccio merged commit 7707469 into develop Feb 19, 2025
7 checks passed
@stratoivandiluccio stratoivandiluccio deleted the P4PU-848 branch February 19, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants