Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [P4PU-884] footer refactored and TOS and PP available again to unlogged user #251

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

stratoivandiluccio
Copy link
Contributor

@stratoivandiluccio stratoivandiluccio commented Feb 25, 2025

List of Changes

This OR includes:

  • Footer refactoring
  • footer links opens in a new tab
  • updated TOS and PP onetrust resource links

Motivation and Context

The PP e TOS pages needs to be available to all users and not only to logged ones

How Has This Been Tested?

Tested manually and running unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 95.73% (🎯 80%) 3836 / 4007
🔵 Statements 95.73% 3836 / 4007
🔵 Functions 87.68% 178 / 203
🟢 Branches 86.53% (🎯 80%) 392 / 453
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/Footer.tsx 100% 75% 60% 100%
src/routes/Resources/index.tsx 89.28% 40% 100% 89.28% 12, 17, 22
Generated in workflow #316 for commit 3be717b by the Vitest Coverage Report Action

@stratoivandiluccio stratoivandiluccio changed the title fix: [P4PU-884] footer refactored and TOS and PP available again to unlogged user feat: [P4PU-884] footer refactored and TOS and PP available again to unlogged user Feb 25, 2025
@stratoivandiluccio stratoivandiluccio self-assigned this Feb 25, 2025
@stratoivandiluccio stratoivandiluccio marked this pull request as ready for review February 25, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant