Fixing tests and adding comment

pagopa · Nov 19, 2024 · 1540245 · 1540245
1 parent 6e3b3d9
commit 1540245
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/packages/delegation-process/test/approveProducerDelegation.test.ts b/packages/delegation-process/test/approveProducerDelegation.test.ts
@@ -93,12 +93,12 @@ describe("approve producer delegation", () => {
       payload: event.data,
     });
 
-    const expectedContractFilePath = (
+    const actualConractPath = (
       await fileManager.listFiles(config.s3Bucket, genericLogger)
     )[0];
 
     const documentId = unsafeBrandId<DelegationContractId>(
-      expectedContractFilePath.split("/")[2]
+      actualConractPath.split("/")[2]
     );
 
     const approvedDelegationWithoutContract: Delegation = {
@@ -123,15 +123,15 @@ describe("approve producer delegation", () => {
         name: `${formatDateyyyyMMddHHmmss(
           currentExecutionTime
         )}_delegation_activation_contract.pdf`,
-        path: expectedContractFilePath,
+        path: actualConractPath,
         prettyName: "Delega",
       },
     });
     expect(actualDelegation).toEqual(expectedDelegation);
 
     const actualContract = await fileManager.get(
       config.s3Bucket,
-      expectedContractFilePath,
+      actualConractPath,
       genericLogger
     );
 
@@ -153,6 +153,7 @@ describe("approve producer delegation", () => {
       genericLogger
     );
 
+    // TODO fix this, it's not really working
     expect(flushPDFMetadata(actualContract, currentExecutionTime)).toEqual(
       flushPDFMetadata(expectedContract, currentExecutionTime)
     );

diff --git a/packages/delegation-process/test/revokeProducerDelegation.test.ts b/packages/delegation-process/test/revokeProducerDelegation.test.ts
@@ -179,12 +179,12 @@ describe("revoke producer delegation", () => {
       payload: event.data,
     });
 
-    const expectedContractFilePath = (
+    const actualContractPath = (
       await fileManager.listFiles(config.s3Bucket, genericLogger)
     )[0];
 
     const documentId = unsafeBrandId<DelegationContractId>(
-      expectedContractFilePath.split("/")[2]
+      actualContractPath.split("/")[2]
     );
 
     const revokedDelegationWithoutContract: Delegation = {
@@ -209,15 +209,15 @@ describe("revoke producer delegation", () => {
         name: `${formatDateyyyyMMddHHmmss(
           currentExecutionTime
         )}_delegation_revocation_contract.pdf`,
-        path: expectedContractFilePath,
+        path: actualContractPath,
         prettyName: "Revoca della delega",
       },
     });
     expect(actualDelegation).toEqual(expectedDelegation);
 
     const actualContract = await fileManager.get(
       config.s3Bucket,
-      expectedContractFilePath,
+      actualContractPath,
       genericLogger
     );
 
@@ -239,6 +239,7 @@ describe("revoke producer delegation", () => {
       genericLogger
     );
 
+    // TODO fix this, it's not really working
     expect(flushPDFMetadata(actualContract, currentExecutionTime)).toEqual(
       flushPDFMetadata(expectedContract, currentExecutionTime)
     );