PIN-5555 eservice delegateClientAccess #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paologaleotti
changed the title
paologaleotti
changed the title
MalpenZibo
force-pushed
the
feature/eservice-isdelegable-PIN-5554
branch
from
ffee648
to
0f7ec96
Compare
…b.com/pagopa/interop-be-monorepo into feature/eservice-clientdelegable-PIN-5555
…b.com/pagopa/interop-be-monorepo into feature/eservice-clientdelegable-PIN-5555
…rvice-clientdelegable-PIN-5555
ecamellini
requested changes
Nov 15, 2024
There was a problem hiding this comment.
I left the same comments I left on #1188, furthermore for this PR I would investigate what happens in case of the two updates (eservice draft and after the publication of the eservice). Since the flag isDelegable is editable in both cases, we shall define what happens to this flag and why it shall not be editable if the other is editable
MalpenZibo
force-pushed
the
feature/eservice-isdelegable-PIN-5554
branch
from
2dad452
to
242a9f2
Compare
paologaleotti
requested review from
beetlecrunch,
galales,
AsterITA,
Carminepo2 and
taglioni-r
as code owners
MalpenZibo
approved these changes
Nov 19, 2024
ecamellini
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Leaving the same comment I left in #1188 👇
Three things are still missing IMO:
- Adding the flag into the various read calls in BFF and API GW (only the ones that don't return compact data)
- Adding the flag into the eservice import/export in BFF (see fileUtils.ts)
- Updating the corresponding Bruno calls, performing some manual tests, and adding some test screenshots to the PR
You can use #1109 as a reference for all the points, where I did the same for the isSignalHubEnabled flag.
…rvice-clientdelegable-PIN-5555
…rvice-clientdelegable-PIN-5555
ecamellini
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Looks good!
I would also add a couple of new tests to test the create/update cases where:
- the new flag is set to some value X
- the isDelegable flag is false/undefined
In these cases we shall test that in the eservice the new flag is set to false/undefined, the value of isDelegable, and the value X from the seed is ignored
AsterITA
approved these changes
Nov 25, 2024
Base automatically changed from
feature/eservice-isdelegable-PIN-5554
to
feature/incaricato
November 26, 2024 09:20
…p-be-monorepo into feature/eservice-clientdelegable-PIN-5555
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge before #1188
POST eservice:
GET Eservice:
Eservice su mongo:
update eservice:
GET con flag updated:
producer eservice:
