IMN-268 - Fixing readmodel writer DELETE & UPDATE Descriptor document

[ecamellini]

Closes IMN-268

The issues were happening for two reasons:

1. both UPDATE and DELETE are implemented using more than one subsequent MongoDB updateOne operations. With the first operation updating the version to the new msg.version and the second operation using the same filter "metadata.version": { $lt: msg.version }, the second operation was not being executed.
2. one of the arrayFilters was causing an error as shown in the Jira card: being a filter on two different top-level fields, it must be separated into two different filters

Tests

Manually tested.

Starting model:

1) Updating document

2) Updating interface

3) Deleting interface

4) Deleting document

[ecamellini]

@taglioni-r FYI since you worked on the same functionalities in the last weeks (#179 and #185).

I noticed these issues while working on #198 and testing manually. Unfortunately, the *-readmodel-writer logic is not covered by tests (yet), so these issues can be caught only through manual testing 😢

I remember we discussed also covering readmodel-writer modules with our integration tests - do you know if someone is investigating if/how to do it? In the meantime, I would perform also manual testing on each PR, to catch bugs like this one

[taglioni-r]

@taglioni-r FYI since you worked on the same functionalities in the last weeks (#179 and #185).

I noticed these issues while working on #198 and testing manually. Unfortunately, the *-readmodel-writer logic is not covered by tests (yet), so these issues can be caught only through manual testing 😢

I remember we discussed also covering readmodel-writer modules with our integration tests - do you know if someone is investigating if/how to do it? In the meantime, I would perform also manual testing on each PR, to catch bugs like this one

Hey @ecamellini, thanks for the fix!
For the topic you are raising, I have had #116 and #117 in draft for quite some time: I would definitely add tests there as well. We can just start the conversation with the team.

[galales]

thanks!

[MalpenZibo]

🚀