feat: Initial history clean process #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariannazafarana
requested review from
micdes-pagopa and
galales
as code owners
galales
reviewed
Nov 28, 2023
src/main/java/it/pagopa/interop/signalhub/history/cleanup/repository/SignalRepository.java
Show resolved
Hide resolved
| LocalDate pastDate = LocalDate.now().minus(Long.parseLong(appConfig.getDelayDays()), ChronoUnit.DAYS); | ||
| signalRepository.deleteByDate(pastDate) | ||
| .doOnSuccess(x -> log.info("clean complete with success")) | ||
| .doOnError(ex -> log.error("Find an error {}",ex)) |
There was a problem hiding this comment.
Suggested change
| .doOnError(ex -> log.error("Find an error {}",ex)) | |
| .doOnError(ex -> log.error("Error on signal cleanup {}", ex)) |
| spring.r2dbc.pool.enabled=true | ||
| spring.data.r2dbc.repositories.enabled=true | ||
|
|
||
| pdnd.history-cleanup.delay-days=30 |
There was a problem hiding this comment.
delay days configuration should be injected as env variable
There was a problem hiding this comment.
abbiamo provveduto ad iniettare la variabile di ambiente sulla parte infrastrutturale
There was a problem hiding this comment.
implemented on infra with commit ef8ca8e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.