[#175072065] EXPERIMENTAL: Start io-backend as Azure Function #722

BurnedMarshal · 2020-10-20T15:13:24Z

No description provided.

pagopa-github-bot · 2020-10-20T15:14:41Z

	Warnings
⚠️	Please include a description of your PR changes.

Affected stories

⚙️ #175072065: Considerare il porting del backend su function serverless

New dependencies added: @azure/functions, io-functions-commons and @types/mime.

@azure/functions

Author: Microsoft

Description: Azure Functions types for Typescript

Homepage: http://npmjs.com/package/@azure/functions


Created	almost 2 years ago
Last Updated	5 months ago
License	MIT
Maintainers	5
Releases	7
Keywords	azure-functions and typescript

README

Type definitions for Azure Functions

This package contains type definitions for using TypeScript with Azure Functions.

These typings are for common objects that will be passed to your Azure Functions function code. Azure Functions supports TypeScript development, but does not support directly running TypeScript code without transpilation.

Read more on configuring entry points in your Azure Functions function app.

Install

Because this package only contains TypeScript type definitions, it should be saved under devDependencies.

npm install @azure/functions --save-dev

Usage

import { AzureFunction, Context, HttpRequest } from "@azure/functions";

const index: AzureFunction = async function (context: Context, req: HttpRequest) {
    context.log('JavaScript HTTP trigger function processed a request.');
    if (req.query.name || (req.body && req.body.name)) {
        context.res = {
            status: "200",
            body: "Hello " + (req.query.name || req.body.name)
        };
    } else {
        context.res = {
            status: 400,
            body: "Please pass a name on the query string or in the request body"
        };
    }
}

export { index };

Versions

Versioning of @azure/functions is tied to the version of the Azure Functions Node.js Worker the types were generated from. You can find the Azure Functions Node.js Worker version of a given Function Runtime Version here. It is recommended that you take the latest version available.

Getting Started with Azure Functions

If you are getting started with Azure Functions, you can follow this tutorial to create and deploy your first JavaScript function. We recommend that you use Visual Studio Code and the Azure Functions extension.

The Azure Functions developer guide and the JavaScript-specific developer guide are good resources to gain an understanding of more Azure Functions concepts.

io-functions-commons

Author: https://www.pagopa.gov.it

Description: Common code for Azure functions

Homepage: https://github.com/pagopa/io-functions-commons#readme


Created	over 1 year ago
Last Updated	4 days ago
License	MIT
Maintainers	4
Releases	88
Direct Dependencies	`@azure/cosmos`, `applicationinsights`, `azure-storage`, `cidr-matcher`, `fp-ts`, `helmet`, `helmet-csp`, `io-functions-express`, `io-ts`, `italia-ts-commons`, `node-fetch`, `nodemailer`, `nodemailer-sendgrid`, `referrer-policy`, `rehype-stringify`, `remark-frontmatter`, `remark-parse`, `remark-rehype`, `request-ip`, `ulid`, `unified` and `winston`

README

io-functions-commons

Common code across Azure functions of project IO.

To release a new package on GitHub and npm:

yarn release-it <minor|major|patch>

Upgrading from 13.x to 14.x

Version 14.x is the first version that uses italia-utils 5.x,
a major upgrade to the package that generates the provided Typescript definitions.

This translates in the fact that you must upgrade italia-utils to a version >= 5.x
if you want to upgrade your deps using io-functions-common 14.x.

@types/mime

Author: Unknown

Description: TypeScript definitions for mime

Homepage: http://npmjs.com/package/@types/mime


Created	over 4 years ago
Last Updated	about 2 months ago
License	MIT
Maintainers	1
Releases	17
Direct Dependencies

README

Installation

npm install --save @types/mime

Summary

This package contains type definitions for mime (https://github.com/broofa/node-mime).

Details

Files were exported from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/mime.

Additional Details

Last updated: Wed, 22 Jul 2020 18:12:53 GMT
Dependencies: none
Global values: mime, mimelite

Credits

These definitions were written by Jeff Goddard, and Daniel Hritzkiv.

Generated by 🚫 dangerJS

gunzip · 2020-10-20T15:37:30Z

src/app.ts

-  // Parse an urlencoded body.
-  app.use(bodyParser.urlencoded({ extended: true }));
+    // Parse an urlencoded body.
+    app.use(bodyParser.urlencoded({ extended: true }));


does SPID login work without this?

gunzip · 2020-10-20T15:39:15Z

src/app.ts


  //
  // Define the folder that contains the public assets.
  //

-  app.use(express.static("public"));
+  app.get(/(\.html|\.svg|\.png)$/, async (req, res, next) => {


I guess the result of this call can be cached using appcache, what about this?

balanza · 2020-10-20T19:35:51Z

src/app.ts

+    try {
+      const path = "public" + req.path;
+      if (!fs.existsSync(path)) {
+        return next();
+      }
+      const stat = await fs.promises.stat(path);
+      if (stat.isDirectory()) {
+        return next();
+      }
+      const type = mime.lookup(path);
+      if (type) {
+        const charset = mime.charsets.lookup(type);
+        res.setHeader(
+          "Content-Type",
+          // tslint:disable-next-line: restrict-plus-operands
+          type + (charset ? `; charset=${charset}` : "")
+        );
+      }
+      const content = await fs.promises.readFile(path);
+      res.setHeader("Content-Length", stat.size);
+      res.status(200).send(content);
+    } catch (err) {
+      log.error(`static|Error retrieving static file asset|error:%s`, err);
+      return next(err);
+    }


It's not clear to me why we introduced this behaviour. Besides that, we can put this in a middleware function (req, res, next)=>void and we can give this chunk an explicit meaning.

This logic is required because the express default static folder (ref) doesn't work inside Azure functions. Here we emulate what static middleware does. We can create a specific middleware, but this code will be used only on this endpoint.

we can just move it in a function declared inside the same module

Fixed in 94282ce

src/config.ts

balanza · 2020-10-20T19:41:56Z

src/controllers/__tests__/sessionLockController.test.ts

@@ -175,7 +173,7 @@ describe("SessionLockController#unlockUserSession", () => {
      mockRedisUserMetadataStorage
    );

-    const response = await controller.lockUserSession(req);
+    const response = await controller.unlockUserSession(req);


* update spid-commons * revert typo * update spid-commons

* [#175679733] Add GetSupportToken API * [#175679733] Add tests + minor refactoring * [#175679733] env.example update * [#175679733] Refactor over review * [#175679733] Minor refactor over review * [#175679733] Fix tests * [#175679733] Remove useless attribute * [#175679733] Minor refactor over review * [#175679733] refactor env variable decoding * [#175679733] Fix tests

* [#176003320] Return 500 instead of 401 on system errors * Fix done param Co-authored-by: danilo spinelli <[email protected]>

Co-authored-by: pasqualedevita <>

codecov · 2020-12-05T15:30:18Z

Codecov Report

Merging #722 (94282ce) into master (7e1db7b) will decrease coverage by 0.54%.
The diff coverage is 35.71%.

@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
- Coverage   79.67%   79.13%   -0.55%     
==========================================
  Files          68       68              
  Lines        2298     2320      +22     
  Branches      375      375              
==========================================
+ Hits         1831     1836       +5     
- Misses        454      471      +17     
  Partials       13       13

Impacted Files	Coverage Δ
src/server.ts	`0.00% <ø> (ø)`
src/app.ts	`88.46% <28.00%> (-7.30%)`	⬇️
src/controllers/authenticationController.ts	`95.09% <100.00%> (ø)`
src/types/user.ts	`89.33% <100.00%> (ø)`
src/controllers/sessionLockController.ts	`100.00% <0.00%> (+3.33%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fa3c70...d7312f2. Read the comment docs.

[#175072065] Start io-backend as Azure Function

93c5691

BurnedMarshal added 2 commits October 20, 2020 17:18

[#175072065] Fix test on success unlockUserSession

8a8e8ae

[#175072065] Use an existing url for test X_FORWARDED_PROTO_HEADER

9a5bd62

gunzip reviewed Oct 20, 2020

View reviewed changes

balanza reviewed Oct 20, 2020

View reviewed changes

balanza and others added 24 commits October 21, 2020 10:38

chore: release 7.5.0

67816b2

chore: release 7.6.0

8028b3d

[#174877080] Upgrade to italia-utils 5.x (#711)

fa0147d

[#174877080] Upgrade io utils to v6 (#723)

70bc538

chore: release 7.7.0

f59c56d

[#175072065] Remove DISABLE_BODY_PARSER env variables

e641ee7

[#175072065] staticContentMiddleware become a middleware function

94282ce

[#175499507] update spid-commons (#725)

4a6d18a

* update spid-commons * revert typo * update spid-commons

chore: release 7.7.1

6a7a1d8

[#175434645] Proxy abort user data processing (#724)

07f66d5

chore: release 7.8.0

95de2e8

[#175679733] Rename GetSupport Token endpoint (#727)

26ccedf

chore: release 7.9.0

2e70348

Update azure-pipelines.yml for Azure Pipelines

2ddafb0

[#176003320] Return 500 instead of 401 on system errors (#728)

d2316d8

* [#176003320] Return 500 instead of 401 on system errors * Fix done param Co-authored-by: danilo spinelli <[email protected]>

chore: release 7.9.1

480050e

add second app service (#729)

4c11a09

Co-authored-by: pasqualedevita <>

fix boolean (#730)

7ec83a1

Co-authored-by: pasqualedevita <>

fix parameters boolean (#731)

61cb35a

Co-authored-by: pasqualedevita <>

merged master

a4fb41a

[#175072065] Fix test on success unlockUserSession

3ae06ab

[#175072065] Use an existing url for test X_FORWARDED_PROTO_HEADER

7dba4e6

[#175072065] Remove DISABLE_BODY_PARSER env variables

52ee814

BurnedMarshal and others added 4 commits December 5, 2020 11:37

[#175072065] staticContentMiddleware become a middleware function

08e37de

update yarn.lock

0f5a573

update yarn.lock

d4cf44a

yarn.lock

972ede7

yarn.lock

d7312f2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#175072065] EXPERIMENTAL: Start io-backend as Azure Function #722

[#175072065] EXPERIMENTAL: Start io-backend as Azure Function #722

BurnedMarshal commented Oct 20, 2020

pagopa-github-bot commented Oct 20, 2020 •

edited

Loading

Type definitions for Azure Functions

Install

Usage

Versions

Getting Started with Azure Functions

io-functions-commons

Upgrading from 13.x to 14.x

Installation

Summary

Details

Additional Details

Credits

gunzip Oct 20, 2020

gunzip Oct 20, 2020

balanza Oct 20, 2020

BurnedMarshal Oct 27, 2020

balanza Oct 27, 2020

BurnedMarshal Oct 27, 2020

balanza Oct 20, 2020

codecov bot commented Dec 5, 2020 •

edited

Loading

[#175072065] EXPERIMENTAL: Start io-backend as Azure Function #722

Are you sure you want to change the base?

[#175072065] EXPERIMENTAL: Start io-backend as Azure Function #722

Conversation

BurnedMarshal commented Oct 20, 2020

pagopa-github-bot commented Oct 20, 2020 • edited Loading

Affected stories

Type definitions for Azure Functions

Install

Usage

Versions

Getting Started with Azure Functions

io-functions-commons

Upgrading from 13.x to 14.x

Installation

Summary

Details

Additional Details

Credits

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Dec 5, 2020 • edited Loading

Codecov Report

pagopa-github-bot commented Oct 20, 2020 •

edited

Loading

codecov bot commented Dec 5, 2020 •

edited

Loading