feat: [IOBP-961] German translation as defined in service metadata #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeleDallas
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #442 +/- ##
=======================================
Coverage 63.85% 63.85%
=======================================
Files 167 167
Lines 5437 5437
Branches 746 746
=======================================
Hits 3472 3472
Misses 1964 1964
Partials 1 1 Continue to review full report in Codecov by Sentry.
|
Hantex9
approved these changes
Dec 3, 2024
LeleDallas
added a commit
to pagopa/io-app
that referenced
this pull request
Dec 3, 2024
> [!note] > This PR depends on: > * pagopa/io-dev-api-server#442 ## Short description This pull request includes several changes across multiple files to update the locale data and improve the content reducer. The most important changes include updating YAML file references, adding German locale descriptions to Zendesk categories, and modifying the content reducer to use a different locale function. ## List of changes proposed in this pull request - Updated the `io_content_specs` reference to a new version. - Replaced `getRemoteLocale` with `getCurrentLocale` - Added German (`de-DE`) descriptions to various Zendesk categories and test ## How to test Check FAQ in the application with German language --------- Co-authored-by: Alessandro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR add missing German translation(
de) incontextual_helpdata, as defined in the io-services-metadata repo