Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOCOM-2009] FIMS RP page close link #443

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[IOCOM-2009] FIMS RP page close link #443

merged 1 commit into from
Dec 5, 2024

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR adds the "Close" button the the example authenticated Relying Party's web page.

List of changes proposed in this pull request

  • link (and button) that closes the InApp Browser using the iossoapi protocol

How to test

Using the related IO App branch, check that the In App browser is closed correctly.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.85%. Comparing base (566ed24) to head (2b11f4f).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #443    +/-   ##
========================================
  Coverage   63.85%   63.85%            
========================================
  Files         167      167            
  Lines        5437     5437            
  Branches      746      769    +23     
========================================
  Hits         3472     3472            
+ Misses       1964     1820   -144     
- Partials        1      145   +144     
Files with missing lines Coverage Δ
src/features/fims/services/relyingPartyService.ts 11.94% <ø> (ø)

... and 33 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c73f9...2b11f4f. Read the comment docs.

Copy link
Member

@adelloste adelloste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vangaorth Vangaorth merged commit ff01ec0 into master Dec 5, 2024
8 checks passed
@Vangaorth Vangaorth deleted the IOCOM-2009 branch December 5, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants