chore: [IOBP-1100] Align backend and zendesk json #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeleDallas
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #453 +/- ##
==========================================
- Coverage 63.85% 63.75% -0.11%
==========================================
Files 167 166 -1
Lines 5437 5410 -27
Branches 746 743 -3
==========================================
- Hits 3472 3449 -23
+ Misses 1964 1960 -4
Partials 1 1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
github-merge-queue bot
pushed a commit
to pagopa/io-app
that referenced
this pull request
Jan 10, 2025
## Short description This pull request corrects the display strings for the German FAQ. ## List of changes proposed in this pull request - Update `io-service-metadata` version - Add german key to `localeToLocalizedMessageKey` constant - Added `fallbackForLocalizedMessageKeys` function to provide a fallback for German translations when they are not available - Updated locale handling to use the new fallback mechanism ## How to test > [!IMPORTANT] > Align `io-dev-api-server` with this [PR](pagopa/io-dev-api-server#453) - Select German language, reload the app - Open the app - Tap on FAQ - Ensure that categories and subcategories are in german ## Preview https://github.com/user-attachments/assets/333858a3-d03a-496e-8869-e28f10d2843c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pull request includes multiple changes primarily focused on updating German translations in the
assets/assistanceTools/zendesk.jsonfile, updatingio-services-metadatatov1.0.53in thepackage.json, and adding German translations in thesrc/payloads/backend.tsfile as defined inio-services-metadata