Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOAPPX-484] Upgrade to yarn 3.8.7, remove CdC, remove Docker #465

Merged
merged 11 commits into from
Feb 13, 2025

Conversation

Vangaorth
Copy link
Contributor

@Vangaorth Vangaorth commented Feb 12, 2025

Short description

This PR upgrades yarn to 3.8.7

List of changes proposed in this pull request

  • yarnrc and executable to set the yarn version
  • proper ignores added to .gitignore
  • api generation moved to script sh to share common versions
  • removed unused cdc data
  • removed docker from project
  • yarn.lock regenerated due to switch to yarn 3 (from yarn 1)
  • latest versions for typescript, ts-commons, fp-ts and io-ts

How to test

Using IO-App, check that the io-dev-api-server is still working as expected.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.93%. Comparing base (bde1bd6) to head (c38d167).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   63.90%   63.93%   +0.03%     
==========================================
  Files         166      164       -2     
  Lines        5433     5341      -92     
  Branches      772      703      -69     
==========================================
- Hits         3472     3415      -57     
- Misses       1817     1925     +108     
+ Partials      144        1     -143     
Files with missing lines Coverage Δ
src/features/services/routers/institutions.ts 40.54% <ø> (ø)
src/routers/features/idpay/timeline.ts 100.00% <ø> (ø)
src/server.ts 100.00% <ø> (ø)

... and 43 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ad6b9f...c38d167. Read the comment docs.

@Vangaorth Vangaorth marked this pull request as ready for review February 12, 2025 14:15
@Vangaorth Vangaorth changed the title chore: upgrade to yarn 3.8.7 chore: [IOAPPX-484] Upgrade to yarn 3.8.7 Feb 12, 2025
@Vangaorth Vangaorth changed the title chore: [IOAPPX-484] Upgrade to yarn 3.8.7 chore: [IOAPPX-484] Upgrade to yarn 3.8.7, remove CdC, remove Docker Feb 12, 2025
LeleDallas
LeleDallas previously approved these changes Feb 12, 2025
Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@LeleDallas LeleDallas dismissed their stale review February 12, 2025 15:14

Issue in types

@Vangaorth Vangaorth marked this pull request as draft February 12, 2025 16:58
@Vangaorth Vangaorth marked this pull request as ready for review February 13, 2025 13:27
@Vangaorth
Copy link
Contributor Author

Issue in types

@LeleDallas fixed, can you check it again?

Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue in types

@LeleDallas fixed, can you check it again?

I see no regression this time!

@Vangaorth Vangaorth merged commit 5d7b446 into master Feb 13, 2025
6 checks passed
@Vangaorth Vangaorth deleted the feature/yarn3 branch February 13, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants