[IOPID-2719] FastLogin expiration date #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #467 +/- ##
==========================================
+ Coverage 63.92% 63.97% +0.05%
==========================================
Files 164 164
Lines 5341 5346 +5
Branches 723 703 -20
==========================================
+ Hits 3414 3420 +6
- Misses 1783 1925 +142
+ Partials 144 1 -143
... and 34 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ChrisMattew
requested review from
gispada,
freddi301 and
a team
as code owners
github-merge-queue bot
pushed a commit
to pagopa/io-app
that referenced
this pull request
Feb 19, 2025
>[!Important] >Depends on [this PR](pagopa/io-services-metadata#937) ## Short description This PR implements the FastLogin notification banner in the messages section, displayed when the days left until the `expirationDate` are lower than or equal to the remote `threshold` value ## List of changes proposed in this pull request - Updated the `content` definitions source url - Added the `loginPreferences` in order to handle the local persisted `showSessionExpirationBanner` value - Added the `LoginExpirationBanner` into the `landingScreenBannerMap` - Added tests for `isSessionExpirationBannerRenderableSelector` in order to ensure it works correctly ## Demo <details> <summary>Fast Login</summary> |iOS |Android | |:---------------|:-----------------| |<video src="https://github.com/user-attachments/assets/25161fcb-9bfc-4fd9-986e-76af6cf1808c"></video>|<video src="https://github.com/user-attachments/assets/5cd88c4c-ac9d-413a-9206-762f7e204d9a"></video>| </details> <details> <summary>Standard Login</summary> |iOS |Android | |:---------------|:-----------------| |<video src="https://github.com/user-attachments/assets/8c1593dc-a3a7-47ff-8fda-c2255f8053a9"></video>|<video src="https://github.com/user-attachments/assets/f650d687-44ba-4987-a8f2-33804442cd66"></video>| </details> >[!Note] > For standard login, it is currently not necessary to display the session expiration banner. However, it can be enabled by setting the `standardLogin` threshold field in the remote configuration. ## How to test This feature can be tested in a local environment by running the dev server from the branch of [this PR](pagopa/io-dev-api-server#467). This will allow testing different scenarios by changing the values of `expirationDate` and `loginConfig` as needed. As for the production environment, a proxy tool will be required to manipulate the `expirationDate` field value as needed. --------- Co-authored-by: mariateresaventura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Depends on this PR
Short description
This PR upgrades the
IO_SERVICES_METADATA_VERSIONand theIO_SESSION_MANAGER_VERSION, it adds theloginConfigfield in thesrc/payloads/backend.tsfile and theexpirationDatefield in thePublicSessionobject in order to allow tests in this PRList of changes proposed in this pull request
IO_SERVICES_METADATA_VERSIONIO_SESSION_MANAGER_VERSIONloginConfigfield in thesrc/payloads/backend.tsfileexpirationDatefield in thePublicSessionobjectHow to test
Follow the instruction in this PR