-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CES-208] - Create iopcgnlegalbackupstorage replica in itn #1263
Open
christian-calabrese
wants to merge
7
commits into
main
Choose a base branch
from
CES-208-migrate-iopcgnlegalbackupstorage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CES-208] - Create iopcgnlegalbackupstorage replica in itn #1263
christian-calabrese
wants to merge
7
commits into
main
from
CES-208-migrate-iopcgnlegalbackupstorage
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-calabrese
had a problem deploying
to
prod-ci
October 29, 2024 09:44
— with
GitHub Actions
Failure
christian-calabrese
temporarily deployed
to
prod-ci
October 29, 2024 09:47
— with
GitHub Actions
Inactive
Terraform Plan ('src/domains/cgn/prod') 📖Terraform PlanTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
~ update in-place
Terraform will perform the following actions:
# module.functions.module.function_cgn.azurerm_linux_function_app.this will be updated in-place
~ resource "azurerm_linux_function_app" "this" {
~ app_settings = {
~ "AzureWebJobs.ContinueEycaActivation.Disabled" = "0" -> "1"
# (41 unchanged elements hidden)
}
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-cgn-be-rg/providers/Microsoft.Web/sites/io-p-cgn-fn"
name = "io-p-cgn-fn"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Enti & Servizi"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/domains/cgn/prod"
}
# (31 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
# module.redis.module.redis_cgn.azurerm_redis_cache.this will be updated in-place
~ resource "azurerm_redis_cache" "this" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-cgn/providers/Microsoft.Cache/redis/io-p-redis-cgn-std"
name = "io-p-redis-cgn-std"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Enti & Servizi"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/domains/cgn/prod"
}
# (23 unchanged attributes hidden)
~ redis_configuration {
+ data_persistence_authentication_method = "SAS"
# (16 unchanged attributes hidden)
}
# (5 unchanged blocks hidden)
}
# module.storage_accounts.module.storage_account_legal_backup_itn.azurerm_monitor_metric_alert.storage_account_health_check[0] will be created
+ resource "azurerm_monitor_metric_alert" "storage_account_health_check" {
+ auto_mitigate = false
+ description = "The average availability is less than 99.8%. Runbook: not needed."
+ enabled = true
+ frequency = "PT5M"
+ id = (known after apply)
+ name = "[iopitncgnlegalbackupst01] Low Availability"
+ resource_group_name = "io-p-rg-cgn"
+ scopes = (known after apply)
+ severity = 0
+ tags = {
+ "CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
+ "CreatedBy" = "Terraform"
+ "Environment" = "Prod"
+ "ManagementTeam" = "IO Enti & Servizi"
+ "Owner" = "IO"
+ "Source" = "https://github.com/pagopa/io-infra/blob/main/src/domains/cgn/prod"
}
+ target_resource_location = (known after apply)
+ target_resource_type = (known after apply)
+ window_size = "PT5M"
+ criteria {
+ aggregation = "Average"
+ metric_name = "Availability"
+ metric_namespace = "Microsoft.Storage/storageAccounts"
+ operator = "LessThan"
+ skip_metric_validation = false
+ threshold = 99.8
}
}
# module.storage_accounts.module.storage_account_legal_backup_itn.azurerm_private_endpoint.this["blob"] will be created
+ resource "azurerm_private_endpoint" "this" {
+ custom_dns_configs = (known after apply)
+ id = (known after apply)
+ location = "italynorth"
+ name = "io-p-itn-cgn-legalbackup-blob-pep-01"
+ network_interface = (known after apply)
+ private_dns_zone_configs = (known after apply)
+ resource_group_name = "io-p-rg-cgn"
+ subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/pendpoints"
+ tags = {
+ "CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
+ "CreatedBy" = "Terraform"
+ "Environment" = "Prod"
+ "ManagementTeam" = "IO Enti & Servizi"
+ "Owner" = "IO"
+ "Source" = "https://github.com/pagopa/io-infra/blob/main/src/domains/cgn/prod"
}
+ private_dns_zone_group {
+ id = (known after apply)
+ name = "private-dns-zone-group"
+ private_dns_zone_ids = [
+ "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/privateDnsZones/privatelink.blob.core.windows.net",
]
}
+ private_service_connection {
+ is_manual_connection = false
+ name = "io-p-itn-cgn-legalbackup-blob-pep-01"
+ private_connection_resource_id = (known after apply)
+ private_ip_address = (known after apply)
+ subresource_names = [
+ "blob",
]
}
}
# module.storage_accounts.module.storage_account_legal_backup_itn.azurerm_storage_account.this will be created
+ resource "azurerm_storage_account" "this" {
+ access_tier = "Hot"
+ account_kind = "StorageV2"
+ account_replication_type = "ZRS"
+ account_tier = "Standard"
+ allow_nested_items_to_be_public = true
+ cross_tenant_replication_enabled = true
+ default_to_oauth_authentication = false
+ enable_https_traffic_only = true
+ id = (known after apply)
+ infrastructure_encryption_enabled = false
+ is_hns_enabled = false
+ large_file_share_enabled = (known after apply)
+ local_user_enabled = true
+ location = "italynorth"
+ min_tls_version = "TLS1_2"
+ name = "iopitncgnlegalbackupst01"
+ nfsv3_enabled = false
+ primary_access_key = (sensitive value)
+ primary_blob_connection_string = (sensitive value)
+ primary_blob_endpoint = (known after apply)
+ primary_blob_host = (known after apply)
+ primary_blob_internet_endpoint = (known after apply)
+ primary_blob_internet_host = (known after apply)
+ primary_blob_microsoft_endpoint = (known after apply)
+ primary_blob_microsoft_host = (known after apply)
+ primary_connection_string = (sensitive value)
+ primary_dfs_endpoint = (known after apply)
+ primary_dfs_host = (known after apply)
+ primary_dfs_internet_endpoint = (known after apply)
+ primary_dfs_internet_host = (known after apply)
+ primary_dfs_microsoft_endpoint = (known after apply)
+ primary_dfs_microsoft_host = (known after apply)
+ primary_file_endpoint = (known after apply)
+ primary_file_host = (known after apply)
+ primary_file_internet_endpoint = (known after apply)
+ primary_file_internet_host = (known after apply)
+ primary_file_microsoft_endpoint = (known after apply)
+ primary_file_microsoft_host = (known after apply)
+ primary_location = (known after apply)
+ primary_queue_endpoint = (known after apply)
+ primary_queue_host = (known after apply)
+ primary_queue_microsoft_endpoint = (known after apply)
+ primary_queue_microsoft_host = (known after apply)
+ primary_table_endpoint = (known after apply)
+ primary_table_host = (known after apply)
+ primary_table_microsoft_endpoint = (known after apply)
+ primary_table_microsoft_host = (known after apply)
+ primary_web_endpoint = (known after apply)
+ primary_web_host = (known after apply)
+ primary_web_internet_endpoint = (known after apply)
+ primary_web_internet_host = (known after apply)
+ primary_web_microsoft_endpoint = (known after apply)
+ primary_web_microsoft_host = (known after apply)
+ public_network_access_enabled = true
+ queue_encryption_key_type = "Service"
+ resource_group_name = "io-p-rg-cgn"
+ secondary_access_key = (sensitive value)
+ secondary_blob_connection_string = (sensitive value)
+ secondary_blob_endpoint = (known after apply)
+ secondary_blob_host = (known after apply)
+ secondary_blob_internet_endpoint = (known after apply)
+ secondary_blob_internet_host = (known after apply)
+ secondary_blob_microsoft_endpoint = (known after apply)
+ secondary_blob_microsoft_host = (known after apply)
+ secondary_connection_string = (sensitive value)
+ secondary_dfs_endpoint = (known after apply)
+ secondary_dfs_host = (known after apply)
+ secondary_dfs_internet_endpoint = (known after apply)
+ secondary_dfs_internet_host = (known after apply)
+ secondary_dfs_microsoft_endpoint = (known after apply)
+ secondary_dfs_microsoft_host = (known after apply)
+ secondary_file_endpoint = (known after apply)
+ secondary_file_host = (known after apply)
+ secondary_file_internet_endpoint = (known after apply)
+ secondary_file_internet_host = (known after apply)
+ secondary_file_microsoft_endpoint = (known after apply)
+ secondary_file_microsoft_host = (known after apply)
+ secondary_location = (known after apply)
+ secondary_queue_endpoint = (known after apply)
+ secondary_queue_host = (known after apply)
+ secondary_queue_microsoft_endpoint = (known after apply)
+ secondary_queue_microsoft_host = (known after apply)
+ secondary_table_endpoint = (known after apply)
+ secondary_table_host = (known after apply)
+ secondary_table_microsoft_endpoint = (known after apply)
+ secondary_table_microsoft_host = (known after apply)
+ secondary_web_endpoint = (known after apply)
+ secondary_web_host = (known after apply)
+ secondary_web_internet_endpoint = (known after apply)
+ secondary_web_internet_host = (known after apply)
+ secondary_web_microsoft_endpoint = (known after apply)
+ secondary_web_microsoft_host = (known after apply)
+ sftp_enabled = false
+ shared_access_key_enabled = true
+ table_encryption_key_type = "Service"
+ tags = {
+ "CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
+ "CreatedBy" = "Terraform"
+ "Environment" = "Prod"
+ "ManagementTeam" = "IO Enti & Servizi"
+ "Owner" = "IO"
+ "Source" = "https://github.com/pagopa/io-infra/blob/main/src/domains/cgn/prod"
}
+ blob_properties {
+ change_feed_enabled = false
+ default_service_version = (known after apply)
+ last_access_time_enabled = false
+ versioning_enabled = false
}
+ identity {
+ principal_id = (known after apply)
+ tenant_id = (known after apply)
+ type = "SystemAssigned"
}
+ network_rules (known after apply)
+ queue_properties (known after apply)
+ routing (known after apply)
+ share_properties (known after apply)
}
# module.storage_accounts.module.storage_account_legal_backup_itn.azurerm_storage_account_network_rules.network_rules will be created
+ resource "azurerm_storage_account_network_rules" "network_rules" {
+ bypass = [
+ "AzureServices",
+ "Logging",
+ "Metrics",
]
+ default_action = "Deny"
+ id = (known after apply)
+ ip_rules = (known after apply)
+ storage_account_id = (known after apply)
+ virtual_network_subnet_ids = (known after apply)
}
Plan: 4 to add, 2 to change, 0 to destroy.
Warning: Deprecated Resource
with module.functions.azurerm_app_service_plan.app_service_plan_cgn_common,
on ../_modules/functions_apps/app_service_plan_cgn_common.tf line 1, in resource "azurerm_app_service_plan" "app_service_plan_cgn_common":
1: resource "azurerm_app_service_plan" "app_service_plan_cgn_common" {
The `azurerm_app_service_plan` resource has been superseded by the
`azurerm_service_plan` resource. Whilst this resource will continue to be
available in the 2.x and 3.x releases it is feature-frozen for compatibility
purposes, will no longer receive any updates and will be removed in a future
major release of the Azure Provider.
(and one more similar warning elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.
|
christian-calabrese
temporarily deployed
to
prod-ci
October 29, 2024 10:17
— with
GitHub Actions
Inactive
Krusty93
reviewed
Oct 29, 2024
src/domains/cgn/_modules/storage_accounts/storage_account_legal_backup.tf
Outdated
Show resolved
Hide resolved
christian-calabrese
temporarily deployed
to
prod-ci
October 29, 2024 11:31
— with
GitHub Actions
Inactive
christian-calabrese
temporarily deployed
to
prod-ci
October 29, 2024 13:09
— with
GitHub Actions
Inactive
christian-calabrese
temporarily deployed
to
prod-ci
October 29, 2024 13:13
— with
GitHub Actions
Inactive
christian-calabrese
temporarily deployed
to
prod-ci
October 29, 2024 13:14
— with
GitHub Actions
Inactive
christian-calabrese
temporarily deployed
to
prod-ci
October 29, 2024 13:14
— with
GitHub Actions
Inactive
cfcuffari120400
temporarily deployed
to
prod-ci
November 11, 2024 14:48
— with
GitHub Actions
Inactive
christian-calabrese
temporarily deployed
to
prod-ci
November 13, 2024 11:47
— with
GitHub Actions
Inactive
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Storage accounts must be replicated to italy north in view of the infrastructure migration
Major Changes
Create replication of iopcgnlegalbackupstorage in italy north
Dependencies
Testing
Documentation
Other Considerations