feat: [OI-249] login data status #549
Conversation
mmoio
force-pushed
the
feat/OI-249-idps-loading-status
branch
from
9fe2e4d to
7afb552
Compare
mmoio
had a problem deploying
to
prod/eu-south-1
GitHub Actions
Failure
mmoio
had a problem deploying
to
prod/eu-central-1
GitHub Actions
Failure
mmoio
force-pushed
the
feat/OI-249-idps-loading-status
branch
from
7afb552 to
7d7ec3a
Compare
|
I am not particularly convinced about loading the spinner when the page loads. This causes the user to see the loading every time they land on the page when in fact the time it takes the user to click on the “Entra con SPID” button can be used for background loading. |
|
as a secondary issue, when a client_id is not present in GET I see in console this message, maybe we should think about something more clear
|
mmoio
force-pushed
the
feat/OI-249-idps-loading-status
branch
from
7d7ec3a to
293419c
Compare
I'have changed the error logic, using react-query, but errors should still be handled in some way within the ui/ux. I think it deserves a separate PR |
mmoio
changed the title
- separete api functions - separet login data hook - separetd login buttons - unit test
- adds react-query - refactors api - refactors useLoginData - adds spid skeletons - reduces code repeatition SpidSelection & SpidModal - login refactoring - imporeves error handling
mmoio
force-pushed
the
feat/OI-249-idps-loading-status
branch
from
6eda7d2 to
1b28d77
Compare
| src={clientData?.logoUri} | ||
| alt={clientData?.friendlyName} | ||
| src={clientQuery.data?.logoUri} | ||
| alt={clientQuery.data?.friendlyName || 'PagoPa Logo'} |
There was a problem hiding this comment.
| alt={clientQuery.data?.friendlyName || 'PagoPa Logo'} | |
| alt={clientQuery.data?.friendlyName || 'PagoPA Logo'} |
SpidSelection & SpidModal