feat: lambda update idp status #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Giuseppe Gangemi <[email protected]>
| logger.error("Invalid alarm type: %s", alarm_type) | ||
| return {"statusCode": 400, "body": json.dumps("Invalid alarm type")} | ||
|
|
||
| # Update the S3 asset file with latest IDP status |
There was a problem hiding this comment.
style: this comment could be moved to line 201, over update_s3_asset_file function invocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code for
oneid-lambda-update-idp-statusand the related Github Action to deploy it.This lambda is needed to keep track of IDP status according to the CloudWatch Alarms on the IDP errors.
In particular, it is triggered when the alarm
IDPErrorAlarm-{IDP}related to a specific IDP passes to the stateIN_ALARM. This action will update the state to "KO" for the specified IDP.To keep track of the come-back of the IDP, after this operation, the lambda enables actions (default disabled) for the
IDPSuccessAlarm-{IDP}which is a trigger for the lambda when its status passes toIN_ALARM(meaning that we have had some successful logins in the last datapoint), in this case the lambda will be triggered and will update the status to "OK" and at the end will disable theIDPSuccessAlarm-{IDP}actions (meaning that the lambda will not be executed anymore for the IDPSuccessAlarm until it will be reactivated by a trigger of IDPErrorAlarm type).The IDP Status informations are stored inside a DynamoDB table and the "latest" status of each idp is also saved inside a .json file of the
assetsbucket to enable a quick retrieval from the frontend.