Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename teamdigitale/italia-* repos to teamdigitale/io-* #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alranel
Copy link

@alranel alranel commented Feb 16, 2019

No description provided.

@digitalcitizenship
Copy link

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

⚠️

Please include a description of your PR changes.

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

@cloudify
Copy link
Contributor

how is publishing to npm affected? (i.e. https://www.npmjs.com/package/italia-utils)

need also to change all references in package.json from the app, functions, utils, pagopa, etc...

@alranel
Copy link
Author

alranel commented Feb 16, 2019

@cloudify I created PRs for all repositories. Now I think we just need to re-publish stuff on npmjs. I can't find how this particular repo is published, maybe it's done manually instead of CircleCI?

package.json Outdated
@@ -2,7 +2,7 @@
"name": "italia-utils",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the package name, referenced from the app, backend and pagopa proxy

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, right. I'll go through these package names as well

@@ -22,7 +22,7 @@
},
"dependencies": {
"fs-extra": "^6.0.0",
"italia-ts-commons": "^2.14.0",
"io-ts-commons": "^2.14.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that the name of packages in npm is still italia-utils and italia-ts-commons so this cannot work

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gunzip I think we can close di PR (was create on feb 2019)

@gunzip gunzip added the on-hold label Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants