fix-api-auth-token

pagopa · May 13, 2024 · 25dc837 · 25dc837
1 parent 7810c61
commit 25dc837
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 11 deletions.
diff --git a/src/main/java/it/gov/pagopa/payhub/auth/controller/AuthController.java b/src/main/java/it/gov/pagopa/payhub/auth/controller/AuthController.java
@@ -7,7 +7,7 @@
 @RequestMapping("/payhub")
 interface AuthController {
 
-    @PostMapping("/auth")
+    @GetMapping("/auth")
     @ResponseStatus(code = HttpStatus.OK)
     void authToken(@RequestParam String token);
 }
diff --git a/src/test/java/it/gov/pagopa/payhub/auth/controller/AuthControllerTest.java b/src/test/java/it/gov/pagopa/payhub/auth/controller/AuthControllerTest.java
@@ -17,9 +17,7 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.mockito.Mockito.doNothing;
-import static org.mockito.Mockito.when;
 import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
-import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
 
 @WebMvcTest(AuthControllerImpl.class)
@@ -35,23 +33,23 @@ class AuthControllerTest {
     AuthService authServiceMock;
 
     @Test
-    void authToken() throws Exception {
+    void authTokenOk() throws Exception {
         doNothing().when(authServiceMock).authToken("token");
 
         MvcResult result = mockMvc.perform(
-                post("/payhub/auth")
+                get("/payhub/auth")
                         .param("token", "token")
         ).andExpect(status().is2xxSuccessful()).andReturn();
 
         Assertions.assertNotNull(result);
     }
 
     @Test
-    void authToken1() throws Exception {
+    void authTokenThrowMissingServletRequestParameterException() throws Exception {
         doNothing().when(authServiceMock).authToken("token");
 
         MvcResult result = mockMvc.perform(
-                post("/payhub/auth")
+                get("/payhub/auth")
         ).andExpect(status().isBadRequest()).andReturn();
 
         ErrorDTO actual = objectMapper.readValue(result.getResponse().getContentAsString(),

diff --git a/src/test/java/it/gov/pagopa/payhub/auth/service/AuthServiceTest.java b/src/test/java/it/gov/pagopa/payhub/auth/service/AuthServiceTest.java
@@ -50,7 +50,7 @@ void clean(){
         wireMockServer.stop();
     }
     @Test
-    void authToken() throws Exception {
+    void authTokenOk() throws Exception {
         String token = utils.generateJWK(EXPIRES_AT);
         Map<String, String> claimsMap = createJWKClaims(ISS, AUD);
 

diff --git a/src/test/java/it/gov/pagopa/payhub/auth/utils/JWTValidatorTest.java b/src/test/java/it/gov/pagopa/payhub/auth/utils/JWTValidatorTest.java
@@ -37,7 +37,7 @@ void clean(){
     }
 
     @Test
-    void validateToken() throws Exception {
+    void givenValidTokenThenSuccess() throws Exception {
         String token = utils.generateJWK(new Date(System.currentTimeMillis() + 3600000));
 
         String urlJwkProvider = utils.getUrlJwkProvider();
@@ -48,15 +48,15 @@ void validateToken() throws Exception {
     }
 
     @Test
-    void validate_ExpiredToken_ThrowsTokenExpiredException() throws Exception {
+    void givenTokenThenThrowTokenExpiredException() throws Exception {
         String expiredToken = utils.generateJWK(new Date(System.currentTimeMillis() - 3600000));
         String urlJwkProvider = utils.getUrlJwkProvider();
 
         assertThrows(TokenExpiredException.class, () -> jwtValidator.validate(expiredToken, urlJwkProvider));
     }
 
     @Test
-    void validate_InvalidToken_ThrowsInvalidTokenException() {
+    void givenTokenThenThrowInvalidTokenException() {
         String invalidToken = "your_invalid_token_here";
         String urlJwkProvider = "your_jwk_provider_url_here";