feat: P4ADEV-791-P4PA-AUTH-API-censimento-client-id #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TH-API-censimento-client-id # Conflicts: # src/main/java/it/gov/pagopa/payhub/auth/controller/AuthzControllerImpl.java # src/main/java/it/gov/pagopa/payhub/auth/service/AuthzService.java # src/main/java/it/gov/pagopa/payhub/auth/service/AuthzServiceImpl.java # src/test/java/it/gov/pagopa/payhub/auth/service/AuthzServiceTest.java
macacia
requested review from
antonioT90,
LarissaASLeite,
antocalo,
Benedetta-fabbri and
a team
as code owners
macacia
changed the title
antonioT90
requested changes
Sep 27, 2024
src/main/java/it/gov/pagopa/payhub/auth/controller/AuthzControllerImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/it/gov/pagopa/payhub/auth/controller/AuthzControllerImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/it/gov/pagopa/payhub/auth/repository/ClientRepositoryExtImpl.java
Outdated
Show resolved
Hide resolved
...in/java/it/gov/pagopa/payhub/auth/service/a2a/registration/ClientSecretGeneratorService.java
Outdated
Show resolved
Hide resolved
...in/java/it/gov/pagopa/payhub/auth/service/a2a/registration/ClientSecretGeneratorService.java
Outdated
Show resolved
Hide resolved
src/main/java/it/gov/pagopa/payhub/auth/service/a2a/retreive/ClientDTOMapper.java
Outdated
Show resolved
Hide resolved
.../java/it/gov/pagopa/payhub/auth/controller/AuthzControllerNoOrganizzationAccessModeTest.java
Outdated
Show resolved
Hide resolved
.../java/it/gov/pagopa/payhub/auth/controller/AuthzControllerNoOrganizzationAccessModeTest.java
Outdated
Show resolved
Hide resolved
macacia
changed the title
… requested changes
|
refactoring completed, take a look |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The automatic code review has failed, please take a look and resolve |
|
It's failed due to the fake password used during the unit test |
antonioT90
requested changes
Oct 1, 2024
src/main/java/it/gov/pagopa/payhub/auth/controller/AuthzControllerImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/it/gov/pagopa/payhub/auth/repository/ClientRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/it/gov/pagopa/payhub/auth/service/AuthzServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/it/gov/pagopa/payhub/auth/service/a2a/retreive/ClientMapper.java
Outdated
Show resolved
Hide resolved
src/test/java/it/gov/pagopa/payhub/auth/service/client/retrieve/ClientMapperTest.java
Outdated
Show resolved
Hide resolved
src/test/java/it/gov/pagopa/payhub/auth/service/client/retrieve/ClientMapperTest.java
Outdated
Show resolved
Hide resolved
...it/gov/pagopa/payhub/auth/service/user/registration/ExternalUserIdObfuscatorServiceTest.java
Outdated
Show resolved
Hide resolved
…ng to requested changes
antonioT90
requested changes
Oct 2, 2024
src/main/java/it/gov/pagopa/payhub/auth/service/a2a/ClientService.java
Outdated
Show resolved
Hide resolved
src/main/java/it/gov/pagopa/payhub/auth/service/a2a/ClientServiceImpl.java
Outdated
Show resolved
Hide resolved
src/test/java/it/gov/pagopa/payhub/auth/service/AuthzServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/it/gov/pagopa/payhub/auth/service/a2a/ClientServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/it/gov/pagopa/payhub/auth/service/a2a/retrieve/ClientMapperTest.java
Outdated
Show resolved
Hide resolved
src/test/java/it/gov/pagopa/payhub/auth/service/a2a/retrieve/ClientMapperTest.java
Outdated
Show resolved
Hide resolved
src/test/java/it/gov/pagopa/payhub/auth/service/a2a/retrieve/ClientMapperTest.java
Outdated
Show resolved
Hide resolved
src/test/java/it/gov/pagopa/payhub/auth/service/a2a/retrieve/ClientMapperTest.java
Outdated
Show resolved
Hide resolved
|
SonarCloud reports 3 new issues requiring attention and we need more unit tests. All code we write must be covered by unit tests https://sonarcloud.io/component_measures?id=pagopa_p4pa-auth&pullRequest=80&metric=new_coverage&view=list |
antonioT90
requested changes
Oct 3, 2024
src/main/java/it/gov/pagopa/payhub/auth/service/a2a/retreive/ClientMapper.java
Outdated
Show resolved
Hide resolved
src/test/java/it/gov/pagopa/payhub/auth/service/a2a/retrieve/ClientMapperTest.java
Outdated
Show resolved
Hide resolved
src/main/java/it/gov/pagopa/payhub/auth/service/a2a/retreive/ClientMapper.java
Outdated
Show resolved
Hide resolved
…e to Code scanning alerts
antonioT90
requested changes
Oct 4, 2024
src/test/java/it/gov/pagopa/payhub/auth/utils/AESUtilsTest.java
Outdated
Show resolved
Hide resolved
…ng to requested changes
src/test/java/it/gov/pagopa/payhub/auth/utils/AESUtilsTest.java
Dismissed
Show dismissed
Hide dismissed
|
There are 9 issues, must be 0. |
antonioT90
requested changes
Oct 4, 2024
src/main/java/it/gov/pagopa/payhub/auth/mapper/ClientMapper.java
Outdated
Show resolved
Hide resolved
src/test/java/it/gov/pagopa/payhub/auth/mapper/ClientMapperTest.java
Outdated
Show resolved
Hide resolved
src/test/java/it/gov/pagopa/payhub/auth/mapper/ClientMapperTest.java
Outdated
Show resolved
Hide resolved
src/test/java/it/gov/pagopa/payhub/auth/mapper/ClientMapperTest.java
Outdated
Show resolved
Hide resolved
src/test/java/it/gov/pagopa/payhub/auth/mapper/ClientMapperTest.java
Outdated
Show resolved
Hide resolved
src/test/java/it/gov/pagopa/payhub/auth/mapper/ClientMapperTest.java
Outdated
Show resolved
Hide resolved
|
@macacia there is still an unresolved conversation! the comment is inside the src/test/java/it/gov/pagopa/payhub/auth/service/a2a/ClientServiceTest.java file |
antonioT90
approved these changes
Oct 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
List of Changes
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: