Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [CHK-2640] Back loop between select method and insert email #330

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

petretiandrea
Copy link
Contributor

@petretiandrea petretiandrea commented Apr 16, 2024

The loop between select method page and insert email page when pressing back button is caused by pushing another email page on history stack. The email page use navigate(-1) on back press and the previously page is select method when coming from it, so this generate a loop. To solve it, just pop from history stack the select method page to go back to email page.

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@petretiandrea petretiandrea marked this pull request as ready for review April 16, 2024 16:12
@petretiandrea petretiandrea requested a review from a team as a code owner April 16, 2024 16:12
@petretiandrea petretiandrea merged commit 915d141 into develop Apr 17, 2024
3 of 4 checks passed
@petretiandrea petretiandrea deleted the CHK-2640-fix-loop-back branch April 17, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants