Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [CHK-2839] Remove GDI verification from checkout #349

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: [CHK-2839] Remove GDI verification from checkout #349

wants to merge 1 commit into from

Conversation

petretiandrea
Copy link
Contributor

@petretiandrea petretiandrea commented May 21, 2024 •
edited
Loading

This PR remove GDI check page.

List of Changes

  • remove page
  • remove route enum
  • adapt tests

Motivation and Context

The GDI-check will be performed by ecommerce-fe page. Transaction service will be update to return a redirection to url to ecommerce-fe (see pagopa/pagopa-ecommerce-transactions-service#498).

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@petretiandrea petretiandrea marked this pull request as ready for review May 21, 2024 16:01
@petretiandrea petretiandrea requested a review from a team as a code owner May 21, 2024 16:01
@petretiandrea petretiandrea requested a review from vito80ba May 22, 2024 09:03
@petretiandrea petretiandrea force-pushed the CHK-2839-remove-gdi-verification branch from e724c15 to e0511c2 Compare May 22, 2024 09:48
infantesimone
infantesimone requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@infantesimone infantesimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, we need to keep develop clean to run tests in prod with NPG

@ciuffagianluca ciuffagianluca changed the base branch from develop to main September 20, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infantesimone infantesimone infantesimone requested changes

@vito80ba vito80ba vito80ba approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petretiandrea @vito80ba @infantesimone