Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [CHK-2839] ecommerce fe gdi #350

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

petretiandrea
Copy link
Contributor

This PR enables to handle GDI check page and esito page to be properly redirected when transaction service returns it during authorization request.

List of Changes

  • add regex on pathname returned by transaction-service authorization request response
  • add redirection using regex

Motivation and Context

The GDI-check will be performed by ecommerce-fe page. Transaction service will be update to return a redirection to url to ecommerce-fe (see pagopa/pagopa-ecommerce-transactions-service#498).

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@petretiandrea petretiandrea requested a review from a team as a code owner May 22, 2024 09:45
@@ -35,3 +35,9 @@
return "";
}
}

const eCommerceFrontendPathNameRegex = new RegExp(
process.env.CHECKOUT_ECOMMERCE_FRONTEND_REDIRECT_REGEX || "^/ecommerce-fe"

Check failure

Code scanning / CodeQL

Regular expression injection High

This regular expression is constructed from a
environment variable
.
@ciuffagianluca ciuffagianluca changed the base branch from develop to main September 20, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants