CHK-3703 login button #436
Open
+428
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 17, 2025 17:58
[CHK-3717] feat: add authentication integration test
[CHK-3716] add auth service api
|
🎉 All dependencies have been resolved ! |
dylantangredi-bvt
previously approved these changes
Feb 25, 2025
dylantangredi-bvt
previously approved these changes
Feb 25, 2025
dylantangredi-bvt
previously approved these changes
Feb 25, 2025
infantesimone
requested changes
Feb 25, 2025
| ? { xs: "background.paper" } | ||
| : { xs: "background.default" }), | ||
| sm: "background.paper", | ||
| ...(isFixed() ? { xs: "#f2f2f2" } : { xs: "background.default" }), |
There was a problem hiding this comment.
Why is the footer fixed in this PR?
There was a problem hiding this comment.
Why is background.paper no longer valid?
| @@ -47,6 +51,9 @@ export default function Header() { | |||
| }; | |||
| const CartInfo = getSessionItem(SessionItems.cart) as Cart | undefined; | |||
| const [drawstate, setDrawstate] = React.useState(false); | |||
| const [enableAuthentication, setEnableAuthentication] = React.useState( | |||
| getSessionItem(SessionItems.enableAuthentication) === "true" | |||
| ); | |||
| const ignoreRoutes: Array<string> = [ | |||
There was a problem hiding this comment.
Suggested change
| const ignoreRoutes: Array<string> = [ | |
| const ignoredRoutesForLogin: Array<string> = [ |
Or something like that, to make it clear that these are the paths that should not show the login button.
| const [error, setError] = React.useState(""); | ||
| const [errorModalOpen, setErrorModalOpen] = React.useState(false); | ||
|
|
||
| const onError = (m: string) => { |
There was a problem hiding this comment.
Is this error exclusively dedicated to the URL request phase to proceed with the login? Perhaps the error handling will need to be further explored in a dedicated PR
| onError: (e: string) => void; | ||
| onResponse: (r: any) => void; | ||
| }) => { | ||
| const token = await callRecaptcha(recaptchaRef, true); |
There was a problem hiding this comment.
why not include in chain? something like
Suggested change
| const token = await callRecaptcha(recaptchaRef, true); | |
| pipe( | |
| fromNullable(token), | |
| fromOption(() => { | |
| onError(ErrorsType.GENERIC_ERROR); | |
| return 'Token missing'; | |
| }), | |
| chain(...) |
Co-authored-by: Simone infante <[email protected]>
Co-authored-by: Simone infante <[email protected]>
Co-authored-by: Simone infante <[email protected]>
Co-authored-by: Simone infante <[email protected]>
Co-authored-by: Simone infante <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on pagopa/pagopa-infra#2803, pagopa/pagopa-infra#2806, pagopa/pagopa-checkout-be-mock#91
This PR contains all PRs that introduce logins button to checkout fe pages
List of Changes
Motivation and Context
How Has This Been Tested?
Integration test
Screenshots (if appropriate):
Login
Logged user
Logout
Types of changes
Checklist: