[CHK-3734] add authentication callback route #445
+79
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciuffagianluca
changed the base branch from
main
to
CHK-3704-auth-outcome-management
| const authCode = searchParams.get("auth-code"); | ||
|
|
||
| //if auth code exists save into session storage | ||
| if(authCode != null) |
There was a problem hiding this comment.
What happens if authCode is null? In this case, invoking the post auth is unnecessary, so maybe we should display an error message and allow payment in guest mode?
There was a problem hiding this comment.
If authCode is null error message popup is displayed without call api, but this implementation is added in the PR that extend this one with post auth api call.
There was a problem hiding this comment.
OK, right, error handling is out of scope for the PR 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
auth-callbackpageMotivation and Context
The goal of this PR is to add callback page where auth code is retrieving and then go back to saved page
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: