Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PRDP-122 rework with node engine #44

Merged
merged 59 commits into from
Sep 12, 2023
Merged

feat: PRDP-122 rework with node engine #44

merged 59 commits into from
Sep 12, 2023

Conversation

alessio-cialini
Copy link
Collaborator

@alessio-cialini alessio-cialini commented Aug 30, 2023 •
edited
Loading

List of Changes

  • Refactored pdf generation to use Puppetteer on an Express based application
  • Reworked java process to use the internal Node app for pdf generation, mantaining forefront REST endpoints, validation checks and PDF/A conversion responsabilities
  • Reworked Dockerfile to include Node capabilites

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Alessio Cialini added 10 commits July 4, 2023 12:32
[PRDP-19] feat: defining helm chart tweaks for performance test
98722c7
Merge remote-tracking branch 'origin/main'
6f6796e
Merge branch 'main' of https://github.com/pagopa/pagopa-pdf-engine
835414b
Merge branch 'main' of https://github.com/pagopa/pagopa-pdf-engine
42cb3e9
Merge branch 'main' of https://github.com/pagopa/pagopa-pdf-engine
478e291
[PRDP-122] Introducing rework to include a node engine
298d5a3
[PRDP-122] Updated java module of the engine to contact node service,…
3b2809b 
… removed legacy implementations, updated node engine to report error codes
[PRDP-122] feat: Removed handlebar reference from the java function
0b1c6d6
[PRDP-122] feat: Updated java module tests and docs, updated code_rev…
1b8e9ec 
…iew.yml to consider the specific java folder for the existing code review step
[PRDP-122] feat: Updated release-deploy.yml to consider java folder o…
7ee2cfa 
…n maven release
@pasqualespica pasqualespica changed the title Prdp 122 feat rework with node engine feat: PRDP-122 rework with node engine Aug 31, 2023
@github-actions
Copy link

This pull request does not contain a valid label. Please add one of the following labels: [patch, minor, major, skip]

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

72.8% 72.8% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

pasqualespica
pasqualespica approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work , kudos @alessio-cialini

.github/workflows/code_review.yml
@@ -28,7 +28,7 @@ permissions:

# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
code-review:
code-review-java:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing only node codereview

integration-test/src/step_definitions/pdf_engine_client.js
@@ -3,17 +3,14 @@ const FormData = require('form-data');

const pdf_engine_uri = process.env.PDF_ENGINE_URI;

function generatePDF(zipFile, inputData, engineType) {
function generatePDF(zipFile, inputData) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upd documentation to remove useless param https://pagopa.atlassian.net/wiki/spaces/PPR/pages/718012499/Design+Review+PDF+Engine#Request

node/pdf-generate/function.json
@@ -0,0 +1,18 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it

@pasqualespica pasqualespica merged commit 8d444df into main Sep 12, 2023
6 of 7 checks passed
@pasqualespica pasqualespica temporarily deployed to dev September 12, 2023 13:22 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to dev September 12, 2023 13:24 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to dev September 12, 2023 13:26 — with GitHub Actions Inactive
@jacopocarlini jacopocarlini deleted the PRDP-122-feat-rework-with-node-engine branch June 22, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-cialini alessio-cialini

Labels
major size/large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio-cialini @pasqualespica @alexyey