Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRDP-134] fix node code review and refactor #48

Merged
merged 70 commits into from
Sep 13, 2023
Merged

[PRDP-134] fix node code review and refactor #48

merged 70 commits into from
Sep 13, 2023

Conversation

alessio-cialini
Copy link
Collaborator

@alessio-cialini alessio-cialini commented Sep 13, 2023 •
edited
Loading

List of Changes

  • Refactored Node app to only manage pdf creation, volume management shifted to Java

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Alessio Cialini and others added 30 commits July 4, 2023 12:32
[PRDP-19] feat: defining helm chart tweaks for performance test
98722c7
Merge remote-tracking branch 'origin/main'
6f6796e
Merge branch 'main' of https://github.com/pagopa/pagopa-pdf-engine
835414b
Merge branch 'main' of https://github.com/pagopa/pagopa-pdf-engine
42cb3e9
Merge branch 'main' of https://github.com/pagopa/pagopa-pdf-engine
478e291
[PRDP-122] Introducing rework to include a node engine
298d5a3
[PRDP-122] Updated java module of the engine to contact node service,…
3b2809b 
… removed legacy implementations, updated node engine to report error codes
[PRDP-122] feat: Removed handlebar reference from the java function
0b1c6d6
[PRDP-122] feat: Updated java module tests and docs, updated code_rev…
1b8e9ec 
…iew.yml to consider the specific java folder for the existing code review step
[PRDP-122] feat: Updated release-deploy.yml to consider java folder o…
7ee2cfa 
…n maven release
Merge remote-tracking branch 'origin/main' into PRDP-122-feat-rework-…
50716f7 
…with-node-engine
[PRDP-122] feat: Updated release-deploy.yml and code_review.yml
e52278c
[PRDP-122] feat: Updated Dockerfile for node and java module
418da45
[PRDP-122] chore: Introducing jest in package.json dependencies, move…
770af74 
…d util classes to util folder, introduced jest.config.js
[PRDP-122] chore: Introducing jest in package.json dependencies, move…
416be16 
…d util classes to util folder, introduced jest.config.js
[PRDP-122] chore: Updated jest.config.js, Updated package.json
18551d0
[PRDP-122] feat: introducing node info endpoint jest testing
d110f02
[PRDP-122] feat: Updated node engine tests
c90bc9c
@pasqualespica
try add sidecar #1
6372049
@alexyey
[PRDP-122] Introducing updated actions with customized implementations
42c6b72
@alexyey
Merge remote-tracking branch 'origin/PRDP-122-feat-rework-with-node-e…
576cae9 
…ngine' into PRDP-122-feat-rework-with-node-engine

# Conflicts:
#	helm/values-dev.yaml
@pasqualespica
fix
0dd8a92
@pasqualespica
fix#2
1fd0207
@pasqualespica
fix#3
4933173
@pasqualespica
fix#4
c55ac74
@pasqualespica
fix#5
d8badf7
@pasqualespica
fix#6
a5fadb7
@alexyey
[PRDP-122] Updated HttpTriggerGeneratePDFFunction
540c9d7
@alexyey
Merge remote-tracking branch 'origin/PRDP-122-feat-rework-with-node-e…
27e28fa 
…ngine' into PRDP-122-feat-rework-with-node-engine
@pasqualespica
fix#7
21f7e0a
@github-actions
Copy link

This pull request does not contain a valid label. Please add one of the following labels: [patch, minor, major, skip]

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

pasqualespica
pasqualespica approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pasqualespica pasqualespica merged commit 7abf382 into main Sep 13, 2023
10 of 12 checks passed
@pasqualespica pasqualespica temporarily deployed to dev September 13, 2023 15:14 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to dev September 13, 2023 15:15 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to dev September 13, 2023 15:18 — with GitHub Actions Inactive
@jacopocarlini jacopocarlini deleted the PRDP-134-fix-node-code-review-and-refactor branch June 22, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-cialini alessio-cialini

Labels
minor size/large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio-cialini @pasqualespica @alexyey