feat: Updated error handling with problem-json RFC specs (#5)

Co-authored-by: maxsca <[email protected]>

.gitignore

@@ -38,3 +38,5 @@ hs_err_pid*
 # Helm
 /helm/charts/*
 **/.terraform/
+
+.DS_Store

src/main/java/it/gov/pagopa/wispconverter/config/RedisConfig.java

@@ -1,7 +1,5 @@
 package it.gov.pagopa.wispconverter.config;
 
-import com.fasterxml.jackson.annotation.JsonAutoDetect;
-import com.fasterxml.jackson.annotation.PropertyAccessor;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import org.springframework.beans.factory.annotation.Qualifier;
 import org.springframework.beans.factory.annotation.Value;
@@ -26,13 +24,6 @@ public class RedisConfig {
     @Value("${spring.redis.password}")
     private String password;
 
-    @Bean
-    public ObjectMapper registerObjectMapper() {
-        ObjectMapper objectMapper = new ObjectMapper().findAndRegisterModules();
-        objectMapper.setVisibility(PropertyAccessor.ALL, JsonAutoDetect.Visibility.ANY);
-        return objectMapper;
-    }
-
     @Bean
     public LettuceConnectionFactory registerRedisConnectionFactory() {
         RedisStandaloneConfiguration redisConfiguration = new RedisStandaloneConfiguration(host, port);

src/main/java/it/gov/pagopa/wispconverter/config/UnmarshallerConfig.java

@@ -10,7 +10,6 @@
 
 @Configuration
 public class UnmarshallerConfig {
-
     @Bean
     @Scope("prototype")
     public DocumentBuilderFactory documentBuilderFactory() throws ParserConfigurationException {

src/main/java/it/gov/pagopa/wispconverter/config/WebMvcConfig.java

@@ -2,25 +2,27 @@
 
 import com.fasterxml.jackson.databind.ObjectMapper;
 import it.gov.pagopa.wispconverter.config.model.AppCors;
+import lombok.RequiredArgsConstructor;
 import lombok.SneakyThrows;
 import org.springframework.beans.factory.annotation.Value;
-import org.springframework.context.MessageSource;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.Primary;
-import org.springframework.context.support.ReloadableResourceBundleMessageSource;
+import org.springframework.context.support.ResourceBundleMessageSource;
 import org.springframework.validation.beanvalidation.LocalValidatorFactoryBean;
 import org.springframework.web.servlet.LocaleResolver;
 import org.springframework.web.servlet.config.annotation.CorsRegistry;
 import org.springframework.web.servlet.config.annotation.WebMvcConfigurer;
 import org.springframework.web.servlet.i18n.AcceptHeaderLocaleResolver;
 
+import java.nio.charset.StandardCharsets;
 import java.util.Arrays;
 import java.util.List;
 import java.util.Locale;
 
 
 @Configuration
+@RequiredArgsConstructor
 public class WebMvcConfig implements WebMvcConfigurer {
 
     List<Locale> locales = Arrays.asList(Locale.ENGLISH, Locale.ITALIAN);
@@ -32,13 +34,13 @@ public class WebMvcConfig implements WebMvcConfigurer {
     @SneakyThrows
     @Override
     public void addCorsMappings(CorsRegistry registry) {
-        AppCors appCors = new ObjectMapper().readValue(corsConfiguration,
-                AppCors.class);
+        AppCors appCors = new ObjectMapper().readValue(corsConfiguration, AppCors.class);
         registry.addMapping("/**")
                 .allowedOrigins(appCors.getOrigins())
                 .allowedMethods(appCors.getMethods());
     }
 
+
     @Bean
     public LocaleResolver localeResolver() {
         AcceptHeaderLocaleResolver acceptHeaderLocaleResolver = new AcceptHeaderLocaleResolver();
@@ -47,14 +49,15 @@ public LocaleResolver localeResolver() {
         return acceptHeaderLocaleResolver;
     }
 
+
     @Bean
-    public MessageSource messageSource() {
-        ReloadableResourceBundleMessageSource messageSource =
-                new ReloadableResourceBundleMessageSource();
-        messageSource.setBasename("classpath:messages");
-        messageSource.setDefaultEncoding("UTF-8");
-        messageSource.setUseCodeAsDefaultMessage(true);
-        return messageSource;
+    public ResourceBundleMessageSource messageSource() {
+        var resourceBundleMessageSource=new ResourceBundleMessageSource();
+        resourceBundleMessageSource.setBasename("i18n/messages"); // directory with messages_XX.properties
+        resourceBundleMessageSource.setDefaultLocale(Locale.ENGLISH);
+        resourceBundleMessageSource.setDefaultEncoding(StandardCharsets.UTF_8.name());
+        resourceBundleMessageSource.setAlwaysUseMessageFormat(true);
+        return resourceBundleMessageSource;
     }
 
     @Primary

src/main/java/it/gov/pagopa/wispconverter/controller/RedirectController.java

@@ -13,6 +13,7 @@
 import jakarta.servlet.http.HttpServletResponse;
 import jakarta.validation.constraints.NotBlank;
 import lombok.RequiredArgsConstructor;
+import org.springframework.http.MediaType;
 import org.springframework.validation.annotation.Validated;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.RequestMapping;
@@ -36,7 +37,8 @@ public class RedirectController {
     })
     @GetMapping
     public void redirect(@Parameter(description = "", example = "identificativoIntermediarioPA_sessionId")
-                         @NotBlank(message = "{redirect.session-id.not-blank}") @RequestParam("sessionId") String sessionId,
+                         @NotBlank(message = "{redirect.session-id.not-blank}")
+                             @RequestParam("sessionId") String sessionId,
                          HttpServletResponse response) throws IOException {
         ConversionResultDTO conversionResultDTO = converterService.convert(sessionId);
         response.sendRedirect(conversionResultDTO.getUri());