Fix(pn-12958): fix regression of ApiIntegration Component #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leleOFA
requested review from
ZorbaDimatteo,
AndreaCimini90 and
a team
as code owners
packages/pn-personagiuridica-webapp/src/components/IntegrazioneApi/VirtualKeys.tsx
Outdated
Show resolved
Hide resolved
leleOFA
changed the title
AndreaCimini90
requested changes
Nov 14, 2024
packages/pn-personagiuridica-webapp/src/components/IntegrazioneApi/VirtualKeys.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personagiuridica-webapp/src/pages/ApiIntegration.page.tsx
Outdated
Show resolved
Hide resolved
AndreaCimini90
requested changes
Nov 28, 2024
packages/pn-personagiuridica-webapp/src/pages/ApiIntegration.page.tsx
Outdated
Show resolved
Hide resolved
AndreaCimini90
requested changes
Dec 16, 2024
packages/pn-commons/src/utility/__test__/localization.utility.test.ts
Outdated
Show resolved
Hide resolved
packages/pn-personagiuridica-webapp/src/components/IntegrazioneApi/ApiKeysDataSwitch.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personagiuridica-webapp/src/components/IntegrazioneApi/ApiKeysDataSwitch.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personagiuridica-webapp/src/components/IntegrazioneApi/ApiKeysDataSwitch.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personagiuridica-webapp/src/components/IntegrazioneApi/VirtualKeys.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personagiuridica-webapp/src/components/IntegrazioneApi/VirtualKeysTable.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personagiuridica-webapp/src/pages/ApiIntegration.page.tsx
Outdated
Show resolved
Hide resolved
AndreaCimini90
requested changes
Dec 17, 2024
packages/pn-personagiuridica-webapp/src/utility/apikeys.utility.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personagiuridica-webapp/src/pages/ApiIntegration.page.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personagiuridica-webapp/src/pages/ApiIntegration.page.tsx
Outdated
Show resolved
Hide resolved
AndreaCimini90
previously approved these changes
Jan 3, 2025
AndreaCimini90
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
insert a new state in virtual key table, the choice to insert the chip in fe was made based on the fact that in bff every time the state of a public changes, a call is made to the virtuals which would in turn call the publics again. all this was done to continue working and managing the virtual ones even if there are no active public ones
when change public in not active does one call to api
when create or rotate public called virtual and check issuer api
List of changes proposed in this pull request
How to test
when public is not active the virtual keys with status Active change into Disabled with new color chip