Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [SRTP-302] add global ssl context for client certificate #78

Merged
merged 15 commits into from
Mar 3, 2025
Merged

feat: [SRTP-302] add global ssl context for client certificate #78

merged 15 commits into from
Mar 3, 2025

Conversation

fmuscianisi
Copy link
Collaborator

@fmuscianisi fmuscianisi commented Feb 26, 2025 •
edited
Loading

Description

Creation of the SSL context to be used in mTLS clients from our client certificate.

List of Changes

  • Upload client certificate as a Key Vault secret;
  • Add SslContextFactory to create an SSLContext by means of a SslContextPropsProvider.

Motivation and Context

The SslContextFactory is needed for mTLS clients.

How Has This Been Tested?

  • Pre-Deploy Test
    • Unit
    • Integration (Narrow)
  • Post-Deploy Test
    • Isolated Microservice
    • Broader Integration
    • Acceptance
    • Performance & Load

Types of changes

  • PATCH - Bug fix (backwards compatible bug fixes)
  • MINOR - New feature (add functionality in a backwards compatible manner)
  • MAJOR - Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@fmuscianisi fmuscianisi changed the title Srtp 302 global ssl context client certificate feat: [SRTP-302] add global ssl context for client certificate Feb 26, 2025
@fmuscianisi fmuscianisi marked this pull request as ready for review February 26, 2025 16:36
@fmuscianisi fmuscianisi requested review from a team as code owners February 26, 2025 16:36
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@fmuscianisi fmuscianisi merged commit 38692ee into main Mar 3, 2025
9 checks passed
@fmuscianisi fmuscianisi deleted the SRTP-302-global-ssl-context-client-certificate branch March 3, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaconsalvi lucaconsalvi lucaconsalvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmuscianisi @lucaconsalvi