Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Amended Forex Service and Added Refresh Task #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vijay-kumar-ponraj
Copy link

@vijay-kumar-ponraj vijay-kumar-ponraj commented Nov 18, 2024

Design

  1. Amended the DummyForexService to handle the forex rates fetch
  2. Added Task Scheduler to add tasks for each 4 minutes and added Forex Rates Redis Cache Refresh Job
    • Since API expects all the data to be no more than 5 minutes older, have decided to fetch it for every 4 minutes
    • Cache TTL not set intentionally to make system Available and eventually consistent, if OneFrame service takes more than a minute to return response. User might get outdated data but it won't break, if needed we can add a boolean in API response to safely avoid this response or retry immediately until it become false.

@vijay-kumar-ponraj vijay-kumar-ponraj force-pushed the patch_forex_rate branch 6 times, most recently from d8b89ca to 81de7fe Compare November 18, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant