WIP #18
Open
WIP #18
+1,345
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
October 20, 2015 11:37
|
|
||
| private | ||
| def make_short_url | ||
| self.short_url = SecureRandom.hex(4) if self.short_url.nil? || self.short_url.empty? |
There was a problem hiding this comment.
ActiveSupport adds a blank? method to all objects which helps a bit here.
added 5 commits
October 26, 2015 11:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is mostly done. There is no styling of any kind so the UI is rather plain. I suspect there are large swaths of tests that could be added.
P. S. I had to run rake db:seed RAILS_ENV=test before the rspec suite would run successfully due to the way I did authentication.
@jaybobo @mikegee