rename TransactionKeyValueService to DataKeyValueService (#7307)

rename TransactionKeyValueService to DataKeyValueService

.palantir/revapi.yml

@@ -277,6 +277,130 @@ acceptedBreaks:
         \ ===java.util.Map<com.palantir.atlasdb.keyvalue.api.Cell, byte[]>===)"
       justification: "KeyValueSnapshotReader is a relatively new API and is not widely\
         \ used"
+  "0.1157.0":
+    com.palantir.atlasdb:atlasdb-api:
+    - code: "java.class.removed"
+      old: "interface com.palantir.atlasdb.cell.api.AutoDelegate_TransactionKeyValueService"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.class.removed"
+      old: "interface com.palantir.atlasdb.cell.api.AutoDelegate_TransactionKeyValueServiceManager"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.class.removed"
+      old: "interface com.palantir.atlasdb.cell.api.TransactionKeyValueService"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.class.removed"
+      old: "interface com.palantir.atlasdb.cell.api.TransactionKeyValueServiceManager"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.class.removed"
+      old: "interface com.palantir.atlasdb.spi.TransactionKeyValueServiceConfig"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.class.removed"
+      old: "interface com.palantir.atlasdb.spi.TransactionKeyValueServiceManagerFactory<T\
+        \ extends java.lang.Object>"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.class.removed"
+      old: "interface com.palantir.atlasdb.spi.TransactionKeyValueServiceRuntimeConfig"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.method.parameterTypeChanged"
+      old: "parameter com.palantir.atlasdb.transaction.api.snapshot.KeyValueSnapshotReaderManager\
+        \ com.palantir.atlasdb.transaction.api.snapshot.KeyValueSnapshotReaderManagerFactory::createKeyValueSnapshotReaderManager(===com.palantir.atlasdb.cell.api.TransactionKeyValueServiceManager===,\
+        \ com.palantir.atlasdb.transaction.service.TransactionService, boolean, com.palantir.atlasdb.transaction.api.OrphanedSentinelDeleter,\
+        \ com.palantir.atlasdb.transaction.api.DeleteExecutor, com.palantir.atlasdb.util.MetricsManager)"
+      new: "parameter com.palantir.atlasdb.transaction.api.snapshot.KeyValueSnapshotReaderManager\
+        \ com.palantir.atlasdb.transaction.api.snapshot.KeyValueSnapshotReaderManagerFactory::createKeyValueSnapshotReaderManager(===com.palantir.atlasdb.cell.api.DataKeyValueServiceManager===,\
+        \ com.palantir.atlasdb.transaction.service.TransactionService, boolean, com.palantir.atlasdb.transaction.api.OrphanedSentinelDeleter,\
+        \ com.palantir.atlasdb.transaction.api.DeleteExecutor, com.palantir.atlasdb.util.MetricsManager)"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    com.palantir.atlasdb:atlasdb-config:
+    - code: "java.method.parameterTypeChanged"
+      old: "parameter com.palantir.atlasdb.factory.TransactionManagersInitializer\
+        \ com.palantir.atlasdb.factory.TransactionManagersInitializer::createInitialTables(com.palantir.atlasdb.keyvalue.api.KeyValueService,\
+        \ ===com.palantir.atlasdb.cell.api.TransactionKeyValueServiceManager===, java.util.Set<com.palantir.atlasdb.table.description.Schema>,\
+        \ boolean, boolean)"
+      new: "parameter com.palantir.atlasdb.factory.TransactionManagersInitializer\
+        \ com.palantir.atlasdb.factory.TransactionManagersInitializer::createInitialTables(com.palantir.atlasdb.keyvalue.api.KeyValueService,\
+        \ ===com.palantir.atlasdb.cell.api.DataKeyValueServiceManager===, java.util.Set<com.palantir.atlasdb.table.description.Schema>,\
+        \ boolean, boolean)"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.method.parameterTypeChanged"
+      old: "parameter com.palantir.atlasdb.transaction.api.snapshot.KeyValueSnapshotReaderManagerFactory\
+        \ com.palantir.atlasdb.factory.AtlasDbServiceDiscovery::createKeyValueSnapshotReaderManagerFactoryOfCorrectType(===com.palantir.atlasdb.spi.TransactionKeyValueServiceConfig===)"
+      new: "parameter com.palantir.atlasdb.transaction.api.snapshot.KeyValueSnapshotReaderManagerFactory\
+        \ com.palantir.atlasdb.factory.AtlasDbServiceDiscovery::createKeyValueSnapshotReaderManagerFactoryOfCorrectType(===com.palantir.atlasdb.spi.DataKeyValueServiceConfig===)"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.method.removed"
+      old: "method com.palantir.atlasdb.config.ImmutableAtlasDbConfig com.palantir.atlasdb.config.ImmutableAtlasDbConfig::withTransactionKeyValueService(com.palantir.atlasdb.spi.TransactionKeyValueServiceConfig)"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.method.removed"
+      old: "method com.palantir.atlasdb.config.ImmutableAtlasDbConfig com.palantir.atlasdb.config.ImmutableAtlasDbConfig::withTransactionKeyValueService(java.util.Optional<?\
+        \ extends com.palantir.atlasdb.spi.TransactionKeyValueServiceConfig>)"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.method.removed"
+      old: "method com.palantir.atlasdb.config.ImmutableAtlasDbConfig.Builder com.palantir.atlasdb.config.ImmutableAtlasDbConfig.Builder::transactionKeyValueService(com.palantir.atlasdb.spi.TransactionKeyValueServiceConfig)"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.method.removed"
+      old: "method com.palantir.atlasdb.config.ImmutableAtlasDbConfig.Builder com.palantir.atlasdb.config.ImmutableAtlasDbConfig.Builder::transactionKeyValueService(java.util.Optional<?\
+        \ extends com.palantir.atlasdb.spi.TransactionKeyValueServiceConfig>)"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.method.removed"
+      old: "method com.palantir.atlasdb.config.ImmutableAtlasDbRuntimeConfig com.palantir.atlasdb.config.ImmutableAtlasDbRuntimeConfig::withTransactionKeyValueService(com.palantir.atlasdb.spi.TransactionKeyValueServiceRuntimeConfig)"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.method.removed"
+      old: "method com.palantir.atlasdb.config.ImmutableAtlasDbRuntimeConfig com.palantir.atlasdb.config.ImmutableAtlasDbRuntimeConfig::withTransactionKeyValueService(java.util.Optional<?\
+        \ extends com.palantir.atlasdb.spi.TransactionKeyValueServiceRuntimeConfig>)"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.method.removed"
+      old: "method com.palantir.atlasdb.config.ImmutableAtlasDbRuntimeConfig.Builder\
+        \ com.palantir.atlasdb.config.ImmutableAtlasDbRuntimeConfig.Builder::transactionKeyValueService(com.palantir.atlasdb.spi.TransactionKeyValueServiceRuntimeConfig)"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.method.removed"
+      old: "method com.palantir.atlasdb.config.ImmutableAtlasDbRuntimeConfig.Builder\
+        \ com.palantir.atlasdb.config.ImmutableAtlasDbRuntimeConfig.Builder::transactionKeyValueService(java.util.Optional<?\
+        \ extends com.palantir.atlasdb.spi.TransactionKeyValueServiceRuntimeConfig>)"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.method.removed"
+      old: "method com.palantir.atlasdb.spi.TransactionKeyValueServiceManagerFactory<?>\
+        \ com.palantir.atlasdb.factory.AtlasDbServiceDiscovery::createTransactionKeyValueServiceManagerFactoryOfCorrectType(com.palantir.atlasdb.spi.TransactionKeyValueServiceConfig)"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.method.removed"
+      old: "method java.util.Optional<com.palantir.atlasdb.spi.TransactionKeyValueServiceConfig>\
+        \ com.palantir.atlasdb.config.AtlasDbConfig::transactionKeyValueService()"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.method.removed"
+      old: "method java.util.Optional<com.palantir.atlasdb.spi.TransactionKeyValueServiceConfig>\
+        \ com.palantir.atlasdb.config.ImmutableAtlasDbConfig::transactionKeyValueService()"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.method.removed"
+      old: "method java.util.Optional<com.palantir.atlasdb.spi.TransactionKeyValueServiceRuntimeConfig>\
+        \ com.palantir.atlasdb.config.AtlasDbRuntimeConfig::transactionKeyValueService()"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
+    - code: "java.method.removed"
+      old: "method java.util.Optional<com.palantir.atlasdb.spi.TransactionKeyValueServiceRuntimeConfig>\
+        \ com.palantir.atlasdb.config.ImmutableAtlasDbRuntimeConfig::transactionKeyValueService()"
+      justification: "Renaming TransactionKeyValueService to DataKeyValueService is\
+        \ acceptable as it is marked @Beta and unused in production."
   "0.770.0":
     com.palantir.atlasdb:atlasdb-api:
     - code: "java.class.removed"

atlasdb-api/src/main/java/com/palantir/atlasdb/cell/api/TransactionKeyValueService.java → atlasdb-api/src/main/java/com/palantir/atlasdb/cell/api/DataKeyValueService.java

@@ -40,7 +40,7 @@
  * to transactions.
  */
 @AutoDelegate
-public interface TransactionKeyValueService {
+public interface DataKeyValueService {
     Map<RangeRequest, TokenBackedBasicResultsPage<RowResult<Value>, byte[]>> getFirstBatchForRanges(
             TableReference tableRef, Iterable<RangeRequest> rangeRequests, long timestamp);
 

atlasdb-api/src/main/java/com/palantir/atlasdb/cell/api/TransactionKeyValueServiceManager.java → atlasdb-api/src/main/java/com/palantir/atlasdb/cell/api/DataKeyValueServiceManager.java

@@ -22,8 +22,8 @@
 import java.util.function.LongSupplier;
 
 @AutoDelegate
-public interface TransactionKeyValueServiceManager extends AutoCloseable {
-    TransactionKeyValueService getTransactionKeyValueService(LongSupplier timestampSupplier);
+public interface DataKeyValueServiceManager extends AutoCloseable {
+    DataKeyValueService getDataKeyValueService(LongSupplier timestampSupplier);
 
     Optional<KeyValueService> getKeyValueService();
 

atlasdb-api/src/main/java/com/palantir/atlasdb/spi/TransactionKeyValueServiceConfig.java → atlasdb-api/src/main/java/com/palantir/atlasdb/spi/DataKeyValueServiceConfig.java

@@ -20,6 +20,6 @@
 import com.fasterxml.jackson.annotation.JsonTypeInfo.As;
 
 @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = As.PROPERTY, property = "type", visible = false)
-public interface TransactionKeyValueServiceConfig {
+public interface DataKeyValueServiceConfig {
     String type();
 }

atlasdb-api/src/main/java/com/palantir/atlasdb/spi/TransactionKeyValueServiceManagerFactory.java → atlasdb-api/src/main/java/com/palantir/atlasdb/spi/DataKeyValueServiceManagerFactory.java

@@ -16,14 +16,14 @@
 
 package com.palantir.atlasdb.spi;
 
-import com.palantir.atlasdb.cell.api.TransactionKeyValueServiceManager;
+import com.palantir.atlasdb.cell.api.DataKeyValueServiceManager;
 import com.palantir.atlasdb.coordination.CoordinationService;
 import com.palantir.atlasdb.util.MetricsManager;
 import com.palantir.dialogue.clients.DialogueClients;
 import com.palantir.refreshable.Refreshable;
 
 /**
- * Factory for creating {@link TransactionKeyValueServiceManager} instances.
+ * Factory for creating {@link DataKeyValueServiceManager} instances.
  *
  * Implementations have access to the coordination service to be able query their internal state at a particular
  * timestamp, as well as schedule changes to it at a future timestamp.
@@ -33,19 +33,19 @@
  *
  * @param <T> type used for the coordination state. Should be a jackson-compatible POJO.
  */
-public interface TransactionKeyValueServiceManagerFactory<T> {
+public interface DataKeyValueServiceManagerFactory<T> {
 
     String getType();
 
     Class<T> coordinationValueClass();
 
-    TransactionKeyValueServiceManager create(
+    DataKeyValueServiceManager create(
             String namespace,
             DialogueClients.ReloadingFactory reloadingFactory,
             MetricsManager metricsManager,
             CoordinationService<T> coordinationService,
             KeyValueServiceManager keyValueServiceManager,
-            TransactionKeyValueServiceConfig install,
-            Refreshable<TransactionKeyValueServiceRuntimeConfig> runtime,
+            DataKeyValueServiceConfig install,
+            Refreshable<DataKeyValueServiceRuntimeConfig> runtime,
             boolean initializeAsync);
 }

atlasdb-api/src/main/java/com/palantir/atlasdb/spi/TransactionKeyValueServiceRuntimeConfig.java → atlasdb-api/src/main/java/com/palantir/atlasdb/spi/DataKeyValueServiceRuntimeConfig.java

@@ -19,6 +19,6 @@
 import com.fasterxml.jackson.annotation.JsonTypeInfo;
 
 @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.PROPERTY, property = "type", visible = false)
-public interface TransactionKeyValueServiceRuntimeConfig {
+public interface DataKeyValueServiceRuntimeConfig {
     String type();
 }

atlasdb-api/src/main/java/com/palantir/atlasdb/transaction/api/snapshot/KeyValueSnapshotReaderManagerFactory.java

@@ -16,7 +16,7 @@
 
 package com.palantir.atlasdb.transaction.api.snapshot;
 
-import com.palantir.atlasdb.cell.api.TransactionKeyValueServiceManager;
+import com.palantir.atlasdb.cell.api.DataKeyValueServiceManager;
 import com.palantir.atlasdb.transaction.api.DeleteExecutor;
 import com.palantir.atlasdb.transaction.api.OrphanedSentinelDeleter;
 import com.palantir.atlasdb.transaction.service.TransactionService;
@@ -26,7 +26,7 @@ public interface KeyValueSnapshotReaderManagerFactory {
     String getType();
 
     KeyValueSnapshotReaderManager createKeyValueSnapshotReaderManager(
-            TransactionKeyValueServiceManager transactionKeyValueServiceManager,
+            DataKeyValueServiceManager dataKeyValueServiceManager,
             TransactionService transactionService,
             boolean allowHiddenTableAccess,
             OrphanedSentinelDeleter orphanedSentinelDeleter,

atlasdb-cli/src/test/java/com/palantir/atlasdb/cli/command/KeyValueServiceMigratorsTest.java

@@ -37,7 +37,7 @@
 import com.palantir.atlasdb.keyvalue.api.Cell;
 import com.palantir.atlasdb.keyvalue.api.KeyValueService;
 import com.palantir.atlasdb.keyvalue.api.TableReference;
-import com.palantir.atlasdb.keyvalue.impl.DelegatingTransactionKeyValueServiceManager;
+import com.palantir.atlasdb.keyvalue.impl.DelegatingDataKeyValueServiceManager;
 import com.palantir.atlasdb.keyvalue.impl.InMemoryKeyValueService;
 import com.palantir.atlasdb.keyvalue.impl.TableSplittingKeyValueService;
 import com.palantir.atlasdb.schema.KeyValueServiceMigrator;
@@ -362,7 +362,7 @@ private static AtlasDbServices createMock(KeyValueService kvs, InMemoryTimelockE
         TargetedSweeper sweeper = TargetedSweeper.createUninitializedForTest(kvs, () -> 1);
         SerializableTransactionManager txManager = SerializableTransactionManager.createForTest(
                 metricsManager,
-                new DelegatingTransactionKeyValueServiceManager(kvs),
+                new DelegatingDataKeyValueServiceManager(kvs),
                 timeLock.getLegacyTimelockService(),
                 timestampService,
                 timeLock.getLockService(),

atlasdb-client/src/main/java/com/palantir/atlasdb/AtlasDbConstants.java

@@ -98,7 +98,7 @@ private AtlasDbConstants() {
 
     public static final byte[] DEFAULT_METADATA_COORDINATION_KEY = PtBytes.toBytes("m");
 
-    public static final byte[] DEFAULT_TRANSACTION_KEY_VALUE_SERVICE_COORDINATION_KEY = PtBytes.toBytes("x");
+    public static final byte[] DEFAULT_DATA_KEY_VALUE_SERVICE_COORDINATION_KEY = PtBytes.toBytes("x");
 
     public static final long DEFAULT_TRANSACTION_LOCK_ACQUIRE_TIMEOUT_MS = 60_000;
     public static final int THRESHOLD_FOR_LOGGING_LARGE_NUMBER_OF_TRANSACTION_LOOKUPS = 10_000_000;

atlasdb-client/src/main/java/com/palantir/atlasdb/keyvalue/impl/DelegatingTransactionKeyValueService.java → atlasdb-client/src/main/java/com/palantir/atlasdb/keyvalue/impl/DelegatingDataKeyValueService.java

@@ -18,7 +18,7 @@
 
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.errorprone.annotations.MustBeClosed;
-import com.palantir.atlasdb.cell.api.TransactionKeyValueService;
+import com.palantir.atlasdb.cell.api.DataKeyValueService;
 import com.palantir.atlasdb.keyvalue.api.BatchColumnRangeSelection;
 import com.palantir.atlasdb.keyvalue.api.Cell;
 import com.palantir.atlasdb.keyvalue.api.ColumnRangeSelection;
@@ -34,11 +34,11 @@
 import com.palantir.util.paging.TokenBackedBasicResultsPage;
 import java.util.Map;
 
-public final class DelegatingTransactionKeyValueService implements TransactionKeyValueService {
+public final class DelegatingDataKeyValueService implements DataKeyValueService {
 
     private final KeyValueService delegate;
 
-    public DelegatingTransactionKeyValueService(KeyValueService delegate) {
+    public DelegatingDataKeyValueService(KeyValueService delegate) {
         this.delegate = delegate;
     }
 

atlasdb-client/src/main/java/com/palantir/atlasdb/keyvalue/impl/DelegatingTransactionKeyValueServiceManager.java → atlasdb-client/src/main/java/com/palantir/atlasdb/keyvalue/impl/DelegatingDataKeyValueServiceManager.java

@@ -16,28 +16,28 @@
 
 package com.palantir.atlasdb.keyvalue.impl;
 
+import com.palantir.atlasdb.cell.api.DataKeyValueService;
+import com.palantir.atlasdb.cell.api.DataKeyValueServiceManager;
 import com.palantir.atlasdb.cell.api.DdlManager;
-import com.palantir.atlasdb.cell.api.TransactionKeyValueService;
-import com.palantir.atlasdb.cell.api.TransactionKeyValueServiceManager;
 import com.palantir.atlasdb.keyvalue.api.KeyValueService;
 import java.util.Optional;
 import java.util.function.LongSupplier;
 
-public final class DelegatingTransactionKeyValueServiceManager implements TransactionKeyValueServiceManager {
+public final class DelegatingDataKeyValueServiceManager implements DataKeyValueServiceManager {
 
     private final Optional<KeyValueService> delegate;
-    private final TransactionKeyValueService transactionKeyValueService;
+    private final DataKeyValueService dataKeyValueService;
     private final DdlManager ddlManager;
 
-    public DelegatingTransactionKeyValueServiceManager(KeyValueService delegate) {
+    public DelegatingDataKeyValueServiceManager(KeyValueService delegate) {
         this.delegate = Optional.of(delegate);
-        this.transactionKeyValueService = new DelegatingTransactionKeyValueService(delegate);
+        this.dataKeyValueService = new DelegatingDataKeyValueService(delegate);
         this.ddlManager = new DelegatingDdlManager(delegate);
     }
 
     @Override
-    public TransactionKeyValueService getTransactionKeyValueService(LongSupplier _timestampSupplier) {
-        return transactionKeyValueService;
+    public DataKeyValueService getDataKeyValueService(LongSupplier _timestampSupplier) {
+        return dataKeyValueService;
     }
 
     @Override

atlasdb-config/src/main/java/com/palantir/atlasdb/config/AtlasDbConfig.java

@@ -26,8 +26,8 @@
 import com.palantir.atlasdb.internalschema.InternalSchemaInstallConfig;
 import com.palantir.atlasdb.keyvalue.api.LockWatchCachingConfig;
 import com.palantir.atlasdb.memory.InMemoryAtlasDbConfig;
+import com.palantir.atlasdb.spi.DataKeyValueServiceConfig;
 import com.palantir.atlasdb.spi.KeyValueServiceConfig;
-import com.palantir.atlasdb.spi.TransactionKeyValueServiceConfig;
 import com.palantir.atlasdb.sweep.queue.config.TargetedSweepInstallConfig;
 import com.palantir.exception.NotInitializedException;
 import com.palantir.logsafe.DoNotLog;
@@ -51,7 +51,7 @@ public abstract class AtlasDbConfig {
     public abstract KeyValueServiceConfig keyValueService();
 
     @Beta
-    public abstract Optional<TransactionKeyValueServiceConfig> transactionKeyValueService();
+    public abstract Optional<DataKeyValueServiceConfig> dataKeyValueService();
 
     public abstract Optional<LeaderConfig> leader();