This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
[Named min timestamp leases] Metric tracking fresh ts shortfall #7402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ergo14
force-pushed
the
aa-nmtl-wiring
branch
2 times, most recently
from
68962f6 to
69ff52c
Compare
ergo14
force-pushed
the
aa-nmtl-shortfall-metric
branch
from
b358204 to
81f7ee9
Compare
ergo14
force-pushed
the
aa-nmtl-shortfall-metric
branch
from
81f7ee9 to
80ae615
Compare
Generate changelog in
|
jeremyk-91
reviewed
Oct 30, 2024
| @@ -62,28 +64,38 @@ public final class TimestampLeaseAcquirerImpl implements TimestampLeaseAcquirer | |||
| private final NamespacedTimestampLeaseService delegate; | |||
| private final Unlocker unlocker; | |||
| private final Supplier<UUID> uuidSupplier; | |||
There was a problem hiding this comment.
nit: should have asked on earlier review, but what is the purpose of the UUID supplier? We know from the type that it is a UUID supplier 😅
| responseMap.get(timestampName).getFreshTimestamps().getCount(); | ||
| return returnedTimestamps >= requestedTimestamps; | ||
| }); | ||
| long wereNotFullyFulfilled = requestedFreshTimestamps.keySet().stream() |
There was a problem hiding this comment.
nit: unfulfilledRequestCount or similar?
| unlock(response); | ||
| log.info( | ||
| "Timestamp lease request was not fully fulfilled. This should happen infrequently.", | ||
| SafeArg.of("requests", requests), | ||
| SafeArg.of("requests", request), |
There was a problem hiding this comment.
nit: makes sense, but change the arg name too.
| return new TimestampLeaseAcquirerImpl( | ||
| delegate, | ||
| identifier -> unlock(unlocker, identifier), | ||
| UniqueIds::pseudoRandomUuidV4, |
There was a problem hiding this comment.
Generally in the rest of the code we use UUID::randomUUID. This is plausibly better, but was there a reason for using it here specifically?
| timestampLease: | ||
| docs: Timestamp lease client side telemetry | ||
| metrics: | ||
| notEnoughFreshTimestamps: |
There was a problem hiding this comment.
pedantry: I'd probably have instances somewhere in the name, to be explicit that it's not the amount of shortfall that matters in this count
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-contentious bits from #7400