-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore deprecated ReactDOM methods in Context Menu singleton #7159
Conversation
Generate changelog in
|
Disable ReactDOM API lint deprecations in contextMenuSingletonBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
@@ -50,7 +50,9 @@ export function showContextMenu( | |||
) { | |||
const { | |||
container = document.body, | |||
// eslint-disable-next-line deprecation/deprecation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some sort of react 18 note to these comments so that we can easily track these down later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Added here eb3f5e3
Add comments referencing issueBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Cherry-picked from React 18 Upgrade feature branch #7142
Part of #7165
Preemptively ignores linter errors in anticipation of internal React 18 upgrade. See above issue for more detail.