Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MultiSelect escape behaviour when in an overlay #7201

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bvandercar-vt
Copy link
Contributor

Fixes #7200

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Code Sandbox showing this bug: https://codesandbox.io/p/devbox/blueprint-multiselect-xgr9wh

Steps to reproduce
  1. Have a MultiSelect in a dialog
  2. Bring focus to the MultiSelect combobox tag input
  3. Hit escape key
  4. MultiSelect combobox list of items should close, but the whole dialog closes

Reviewers should focus on:

Fixes this bug

@bvandercar-vt bvandercar-vt force-pushed the bvandercar/fix-multiselect-escape branch 2 times, most recently from a47850f to 8623dda Compare January 29, 2025 16:20
@ashleighp13 ashleighp13 requested a review from ggdouglas January 29, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape keypress in Multiselect that's in a dialog causes the dialog to close
1 participant