Distinguish error logging between thrown Errors and ServiceExceptions #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
|
I frequently search for Can you explain what problem you are trying to solve here? You can always determine the exception thrown by looking at the included stacktrace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
When seeing "Error handling request" in logs, it is difficult to distinguish if the problem is a thrown Error or a thrown ServiceException.
After this PR
==COMMIT_MSG==
Distinguish error logging between thrown Errors and ServiceExceptions
==COMMIT_MSG==
In general, log messages from a class should be unique, so that someone seeing the message and comparing with source code can uniquely identify the location of the log.