Address latest comments

palantir · Dec 14, 2023 · 4fe109d · 4fe109d
1 parent a623131
commit 4fe109d
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 31 deletions.
diff --git a/dialogue-annotations/src/main/java/com/palantir/dialogue/annotations/Constants.java b/dialogue-annotations/src/main/java/com/palantir/dialogue/annotations/Constants.java
diff --git a/...-annotations/src/main/java/com/palantir/dialogue/annotations/InputStreamDeserializer.java b/...-annotations/src/main/java/com/palantir/dialogue/annotations/InputStreamDeserializer.java
@@ -16,16 +16,21 @@
 
 package com.palantir.dialogue.annotations;
 
+import com.palantir.conjure.java.dialogue.serde.DefaultConjureRuntime;
+import com.palantir.conjure.java.dialogue.serde.Encodings;
 import com.palantir.dialogue.BodySerDe;
 import com.palantir.dialogue.Response;
 import java.io.InputStream;
 
 public final class InputStreamDeserializer extends StdDeserializer<InputStream> {
 
+    private static final BodySerDe DEFAULT_BODY_SERDE =
+            DefaultConjureRuntime.builder().encodings(Encodings.json()).build().bodySerDe();
+
     private final BodySerDe bodySerDe;
 
     public InputStreamDeserializer() {
-        this(Constants.DEFAULT_BODY_SERDE);
+        this(DEFAULT_BODY_SERDE);
     }
 
     public InputStreamDeserializer(BodySerDe bodySerDe) {

diff --git a/dialogue-annotations/src/main/java/com/palantir/dialogue/annotations/Json.java b/dialogue-annotations/src/main/java/com/palantir/dialogue/annotations/Json.java
@@ -21,6 +21,7 @@
 import com.fasterxml.jackson.databind.ObjectWriter;
 import com.palantir.conjure.java.dialogue.serde.DefaultConjureRuntime;
 import com.palantir.conjure.java.dialogue.serde.Encoding;
+import com.palantir.conjure.java.dialogue.serde.Encodings;
 import com.palantir.dialogue.BodySerDe;
 import com.palantir.dialogue.TypeMarker;
 import com.palantir.logsafe.Preconditions;
@@ -39,10 +40,13 @@
  */
 public final class Json implements DeserializerFactory<Object>, SerializerFactory<Object> {
 
+    private static final BodySerDe DEFAULT_BODY_SERDE =
+            DefaultConjureRuntime.builder().encodings(Encodings.json()).build().bodySerDe();
+
     private final BodySerDe bodySerDe;
 
     public Json() {
-        this(Constants.DEFAULT_BODY_SERDE);
+        this(DEFAULT_BODY_SERDE);
     }
 
     public Json(ObjectMapper mapper) {