Add socket bind timing metrics

[amerguy]

This metric is helpful to understand networking latencies to help guide reducing connect timeouts.

==COMMIT_MSG==
Add socket bind timing metrics
==COMMIT_MSG==

Possible downsides?

[changelog-app]

Generate changelog in changelog/@unreleased

What do the change types mean?

• feature: A new feature of the service.
• improvement: An incremental improvement in the functionality or operation of the service.
• fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
• break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
  and external consumers of the service's API (e.g. customer-written software or integrations).
• deprecation: Advertises the intention to remove service functionality without any change to the
  operation of the service itself.
• manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
  performing database surgery, ...) at the time of upgrade for it to succeed.
• migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

• ❗The break and manual task changelog types will result in a major release!
• 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
• ✨ All others will result in a minor version release.

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Add socket bind timing metrics

Check the box to generate changelog(s)

• Generate changelog entry

[carterkozak]

Nit: let's factor out the three DialogueClientMetrics.of(metrics) into a local variable which we can reuse for each of the three metric instances we register.

[amerguy]

done in ca0dd32

[carterkozak]

lgtm, thanks!

one sec

[carterkozak]

One sec, I need to review this a bit more closely -- I'm not sure it's doing the right thing

[carterkozak]

I think this currently measures the time it takes to update an AtomicReference. This is the piece we want to measure: SSLConnectionSocketFactory.java#L246 but not this piece: SSLConnectionSocketFactory.java#L260-L264.

[carterkozak]

I can take a closer look tomorrow

[carterkozak]

Closing because #2053 has already merged